[Commits] [wesnoth/wesnoth] fbe7a5: md5: Return a NULL pointer if MD5::raw_digest() is...

GitHub noreply at github.com
Fri Jun 5 06:36:58 UTC 2015


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: fbe7a58c6f06145994dc9ad1f0b10f1f2f01e716
      https://github.com/wesnoth/wesnoth/commit/fbe7a58c6f06145994dc9ad1f0b10f1f2f01e716
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-06-05 (Fri, 05 Jun 2015)

  Changed paths:
    M src/md5.cpp

  Log Message:
  -----------
  md5: Return a NULL pointer if MD5::raw_digest() is called early

This never happens since MD5::raw_digest()'s only caller, util::md5(),
always does it right. However, it's still an open invitation for someone
to read garbage past the end of a 1 byte array, or even worse, write
into it. I'd rather have us crash by dereferencing the null page in that
case instead.


  Commit: 1dd7a4614489cfd300fca60dc4f87a9ae210b113
      https://github.com/wesnoth/wesnoth/commit/1dd7a4614489cfd300fca60dc4f87a9ae210b113
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-06-05 (Fri, 05 Jun 2015)

  Changed paths:
    R README
    A README.md

  Log Message:
  -----------
  Convert our readme file to Markdown


  Commit: 5d993718a67b133a53dd2686f8892ad3d3aa5937
      https://github.com/wesnoth/wesnoth/commit/5d993718a67b133a53dd2686f8892ad3d3aa5937
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-06-05 (Fri, 05 Jun 2015)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: Use -pipe to pipe compiler output directly into the assembler

Instead of using temporary files.


Compare: https://github.com/wesnoth/wesnoth/compare/7be7e3ce8cf8...5d993718a67b


More information about the Commits mailing list