[Commits] [wesnoth/wesnoth] e676f8: refactor play_side

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e676f8904dc2ace2b2da55860e95e8005f224cdd
      https://github.com/wesnoth/wesnoth/commit/e676f8904dc2ace2b2da55860e95e8005f224cdd
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  refactor play_side


  Commit: 4102afce8aaf393e7249ad6339ab580d06272b25
      https://github.com/wesnoth/wesnoth/commit/4102afce8aaf393e7249ad6339ab580d06272b25
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  remove playsingle_controller::play_scenario parameter


  Commit: 6e0db5722bba35b2d7d67e608d6dbed6a6386579
      https://github.com/wesnoth/wesnoth/commit/6e0db5722bba35b2d7d67e608d6dbed6a6386579
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  Use BOOST_FOREACH


  Commit: 2a31aaf9c43a7612d7f8ada339d0445ead63de3e
      https://github.com/wesnoth/wesnoth/commit/2a31aaf9c43a7612d7f8ada339d0445ead63de3e
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  Add comment


  Commit: 5b5916ac6a636df4e48a07c9e89f57395df6b453
      https://github.com/wesnoth/wesnoth/commit/5b5916ac6a636df4e48a07c9e89f57395df6b453
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  remove replaying_ member

replaying_ was always false, as there was previously a code
assert(!replaying_); to test it,


  Commit: 12034ba8a4366a0adc4bf29f970588638c575262
      https://github.com/wesnoth/wesnoth/commit/12034ba8a4366a0adc4bf29f970588638c575262
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/game_end_exceptions.cpp
    M src/game_end_exceptions.hpp

  Log Message:
  -----------
  fixup end_level_data

made is_victory persistent


  Commit: 71164fb5770a40fc6f98100ad75408699ef1d655
      https://github.com/wesnoth/wesnoth/commit/71164fb5770a40fc6f98100ad75408699ef1d655
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  fix check_time_over


  Commit: 54d08359cf45785ef99739ff4d530a2e9dcd5b4c
      https://github.com/wesnoth/wesnoth/commit/54d08359cf45785ef99739ff4d530a2e9dcd5b4c
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/game_initialization/playcampaign.cpp

  Log Message:
  -----------
  fix carryover in mp

previously only the hosts team would get carryover gold.


  Commit: 435accc615ec9f834c9e65a21fedd19a33d0570d
      https://github.com/wesnoth/wesnoth/commit/435accc615ec9f834c9e65a21fedd19a33d0570d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/replay.cpp
    M src/replay.hpp

  Log Message:
  -----------
  remove unused function


  Commit: d35e2a66a65b889fe31500cb19ae631d435e30ef
      https://github.com/wesnoth/wesnoth/commit/d35e2a66a65b889fe31500cb19ae631d435e30ef
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/replay.cpp

  Log Message:
  -----------
  add a check for replay correctness


  Commit: 9df349d646749bc05407d43e4986484922d537e0
      https://github.com/wesnoth/wesnoth/commit/9df349d646749bc05407d43e4986484922d537e0
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/game_events/action_wml.cpp
    M src/synced_context.cpp

  Log Message:
  -----------
  more checks in [do_command]

also we fix run_in_synced_context_if_not_already it it supposed not to
execute the action if we are in a replay in an unsynced context.


  Commit: bfcd2695f29752162d168f9a6759a49bdc5b767f
      https://github.com/wesnoth/wesnoth/commit/bfcd2695f29752162d168f9a6759a49bdc5b767f
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M src/playturn.cpp
    M src/replay.cpp

  Log Message:
  -----------
  don't give OOS error on invalid unit rename

And fix some comments and error message strings.


Compare: https://github.com/wesnoth/wesnoth/compare/f8a2514763b1...bfcd2695f297