[Commits] [wesnoth/wesnoth] 1bd91e: i18n/legacy: Fix typo

GitHub noreply at github.com
Tue Sep 1 01:02:26 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1bd91e75f513e1b439dfaf8363fa8b665a337f61
      https://github.com/wesnoth/wesnoth/commit/1bd91e75f513e1b439dfaf8363fa8b665a337f61
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-08-31 (Mon, 31 Aug 2015)

  Changed paths:
    M src/gettext.cpp

  Log Message:
  -----------
  i18n/legacy: Fix typo

No functional changes.


  Commit: 85cf364ea0c8dc46be268fe065c4d995aa483594
      https://github.com/wesnoth/wesnoth/commit/85cf364ea0c8dc46be268fe065c4d995aa483594
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-08-31 (Mon, 31 Aug 2015)

  Changed paths:
    M changelog
    M players_changelog
    M src/gettext.cpp
    M src/gettext_boost.cpp

  Log Message:
  -----------
  i18n: Skip and warn about textdomain names with a slash (bug #23839)

boost::locale::generator::add_messages_domain() interprets the slash
specially, interpreting everything after it as an encoding name.

It's not clear to me why providing a textdomain with an erroneous name
like this causes Boost.Locale to throw a boost::locale::conv exception
(invalid_charset_error, apparently) when handling t_strings bound to
completely different textdomain, but if we can avoid the issue
altogether then that's good enough.

Made the legacy implementation skip and warn about these names too even
if bindtextdomain(3) says nothing about slashes having a meaning.


  Commit: 2971916edb0e95dbf88b2eeecf1cb0a48c2d4ad2
      https://github.com/wesnoth/wesnoth/commit/2971916edb0e95dbf88b2eeecf1cb0a48c2d4ad2
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2015-08-31 (Mon, 31 Aug 2015)

  Changed paths:
    M src/gettext_boost.cpp

  Log Message:
  -----------
  i18n: Fix typo in log message


Compare: https://github.com/wesnoth/wesnoth/compare/185aa1a2f0c7...2971916edb0e


More information about the Commits mailing list