[Commits] [wesnoth/wesnoth] a33414: Correct doc reference to nonexistent function

Mon Apr 11 05:16:59 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a33414a79f3bc3f59019d9917ac2bcf2587c2185
      https://github.com/wesnoth/wesnoth/commit/a33414a79f3bc3f59019d9917ac2bcf2587c2185
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.hpp

  Log Message:
  -----------
  Correct doc reference to nonexistent function

is_keyboard_scroll_active no longer exists, scrolling_ seems to be the
equivalent.

  Commit: fa756088735d67395fc7dbe04f89890172bcecf6
      https://github.com/wesnoth/wesnoth/commit/fa756088735d67395fc7dbe04f89890172bcecf6
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp
    M src/hotkey/hotkey_command.hpp
    M src/hotkey/hotkey_handler.cpp
    M src/hotkey/hotkey_handler.hpp

  Log Message:
  -----------
  Implement hotkey release handling.

Hotkeys are now triggered by a key/button release as well as a press.
This information is passed along as HOTKEY_EVENT_TYPE, which may be
HOTKEY_EVENT_PRESS, HOTKEY_EVENT_RELEASE, or HOTKEY_EVENT_REPEAT (for a
held key repeat).

Currently this should preserve the previous functionality. Existing
hotkeys respond to a press or repeat as they did before and ignore a
release.

  Commit: 0a05828da38658a31d29be9d6196480a1cd95e96
      https://github.com/wesnoth/wesnoth/commit/0a05828da38658a31d29be9d6196480a1cd95e96
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp
    M src/hotkey/hotkey_command.cpp
    M src/hotkey/hotkey_command.hpp
    M src/hotkey/hotkey_handler.cpp
    M src/hotkey/hotkey_handler.hpp

  Log Message:
  -----------
  Implement map scrolling with hotkeys.

This leverages the new hotkey release support to implement scrolling
with hotkeys rather than keyboard polling.
This allows users to rebind the scroll keys in the hotkey menu.
Previously they were fixed to the arrow keys.

  Commit: f4d2b24a3f9346a02991728c8ba6a6f52a3d8eb0
      https://github.com/wesnoth/wesnoth/commit/f4d2b24a3f9346a02991728c8ba6a6f52a3d8eb0
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp
    M src/hotkey/command_executor.cpp

  Log Message:
  -----------
  Add braces to single-line ifs.

Code review feedback.

  Commit: ae37341ab3b1a58840f4b80b05c2e4a1eb3c1a66
      https://github.com/wesnoth/wesnoth/commit/ae37341ab3b1a58840f4b80b05c2e4a1eb3c1a66
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp
    M src/hotkey/hotkey_command.hpp
    M src/hotkey/hotkey_handler.cpp
    M src/hotkey/hotkey_handler.hpp

  Log Message:
  -----------
  Remove specialized hotkey repeat handling.

Don't handle repeat events specially when triggering hotkeys.
Replace the HOTKEY_EVENT_TYPE enum with a bool indicating whether the
event was a press or a release.

Scrolling handles repeats by clamping the scroll between -1 and 1 so
repeat events don't accelerate the scroll speed.

  Commit: 419bf799acfe65ef23585d623246b632ebd17592
      https://github.com/wesnoth/wesnoth/commit/419bf799acfe65ef23585d623246b632ebd17592
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp

  Log Message:
  -----------
  Handle scrolling hotkeys in editor.

  Commit: a58e595705248cb67e4a703d4cab8f72bf821fe4
      https://github.com/wesnoth/wesnoth/commit/a58e595705248cb67e4a703d4cab8f72bf821fe4
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M data/core/hotkeys.cfg

  Log Message:
  -----------
  Add default hotkeys for map scrolling

  Commit: 4e3d6163360f6ec532436e96e81d37b2c3c200cf
      https://github.com/wesnoth/wesnoth/commit/4e3d6163360f6ec532436e96e81d37b2c3c200cf
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/editor/controller/editor_controller.cpp
    M src/hotkey/hotkey_handler.cpp

  Log Message:
  -----------
  Rename controller_base::keyboard_scroll.

Rename to controller_base::apply_keyboard_scroll to avoid confusion
with hotkey_handler::keyboard_scroll.

keyboard_scroll handles the hotkey press and invokes
apply_keyboard_scroll on the controller.

  Commit: 355b8ce1b81a84ad0d1a11aac3830f87b1f8381a
      https://github.com/wesnoth/wesnoth/commit/355b8ce1b81a84ad0d1a11aac3830f87b1f8381a
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/hotkey/command_executor.cpp

  Log Message:
  -----------
  Restore cycle_units/cycle_back_units hotkeys.

These were accidentally removed while implementing scroll hotkeys.

  Commit: 94e390c067a3535e0a7294e3de3335f16fa2b9f9
      https://github.com/wesnoth/wesnoth/commit/94e390c067a3535e0a7294e3de3335f16fa2b9f9
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp
    M src/hotkey/hotkey_handler.cpp
    M src/hotkey/hotkey_handler.hpp

  Log Message:
  -----------
  Gracefully handle multiple scrolling hotkeys.

Track whether each scroll direction is enabled separately.
This avoids odd behavior when holding multiple hotkeys for the same
scroll direction.
For example, holding two hotkeys for right and releasing both will no
longer cause the map to begin scrolling left.

  Commit: e066075a04f0330effef37c5629754c4271d4640
      https://github.com/wesnoth/wesnoth/commit/e066075a04f0330effef37c5629754c4271d4640
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-05 (Tue, 05 Apr 2016)

  Changed paths:
    M src/controller_base.cpp

  Log Message:
  -----------
  Cleanup: Replace spaces with tabs

  Commit: fd8dfd585349b0c488529723cbba2aa9bc20baa7
      https://github.com/wesnoth/wesnoth/commit/fd8dfd585349b0c488529723cbba2aa9bc20baa7
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-06 (Wed, 06 Apr 2016)

  Changed paths:
    M changelog
    M players_changelog

  Log Message:
  -----------
  Changelog: hotkey release and scroll key binding.

  Commit: 5aecbdbe83344b6e79b62374a79374f54c724710
      https://github.com/wesnoth/wesnoth/commit/5aecbdbe83344b6e79b62374a79374f54c724710
  Author: Ryan Roden-Corrent <ryan at rcorre.net>
  Date:   2016-04-06 (Wed, 06 Apr 2016)

  Changed paths:
    M data/core/about.cfg

  Log Message:
  -----------
  Add self (rcorre) to contributors

  Commit: cdf6f4a6f881a4c9ad2a913859d57dfbdc116369
      https://github.com/wesnoth/wesnoth/commit/cdf6f4a6f881a4c9ad2a913859d57dfbdc116369
  Author: Celtic Minstrel <CelticMinstrel at users.noreply.github.com>
  Date:   2016-04-11 (Mon, 11 Apr 2016)

  Changed paths:
    M changelog
    M data/core/about.cfg
    M data/core/hotkeys.cfg
    M players_changelog
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/command_executor.hpp
    M src/hotkey/hotkey_command.cpp
    M src/hotkey/hotkey_command.hpp
    M src/hotkey/hotkey_handler.cpp
    M src/hotkey/hotkey_handler.hpp

  Log Message:
  -----------
  Merge pull request #631 from rcorre/wasd_scrolling

Add preference for WASD scrolling.

Compare: https://github.com/wesnoth/wesnoth/compare/53f1b5a17085...cdf6f4a6f881