[Commits] [wesnoth/wesnoth] 80c372: Game Config: fixed red_to_green and blue_to_white ...

GitHub noreply at github.com
Thu Dec 1 04:12:16 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 80c372b4a054e2150f57277dc3e8d2af982a59b8
      https://github.com/wesnoth/wesnoth/commit/80c372b4a054e2150f57277dc3e8d2af982a59b8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-12-01 (Thu, 01 Dec 2016)

  Changed paths:
    M src/game_config.cpp

  Log Message:
  -----------
  Game Config: fixed red_to_green and blue_to_white returning incorrect values

The issue was that load_config is (for some reason) called twice, and the respective vectors of colors
were simply added on to each time, resulting in incorrect color values when queried.

I figured it would be slightly more efficient to simply assign the vector a new value since the size remains the same.
I'm not sure if a simple vec.clear() call would be more or as efficient, though, not that it really matters at this size.





More information about the Commits mailing list