[Commits] [wesnoth/wesnoth] c0c4bf: deprecate needs_select=yes

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c0c4bf3314d161339de4de6abe113691d25b4187
      https://github.com/wesnoth/wesnoth/commit/c0c4bf3314d161339de4de6abe113691d25b4187
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2016-12-22 (Thu, 22 Dec 2016)

  Changed paths:
    M src/game_events/menu_item.cpp

  Log Message:
  -----------
  deprecate needs_select=yes

The behaviour of needs_select=yes event is rather strange and hard to understand:
When a menu items with needs_select=yes it clicked, it first fires the previous select event again but this time in a synced context, so that the select event was fires 2 times total on the playing client and one time at the other clients. It also the breaks the specification in the wiki that select events are not fired in synced contexts.

Also it might happen that the unit stands no longer at the position from where it was selected because it has moved causing unexpected behaviour in this case.

The new way to let other clients know the currents selected unit is the [sync_variable] tag which was added in 1.13.