[Commits] [wesnoth/wesnoth] 4915f0: desktop: Add functionality to enumerate paths of i...

GitHub noreply at github.com
Wed Oct 12 06:11:03 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4915f0349c67c2b15130bbaa46acbfc927f427d6
      https://github.com/wesnoth/wesnoth/commit/4915f0349c67c2b15130bbaa46acbfc927f427d6
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-10-12 (Wed, 12 Oct 2016)

  Changed paths:
    M projectfiles/CodeBlocks/wesnoth.cbp
    M src/CMakeLists.txt
    M src/SConscript
    A src/desktop/paths.cpp
    A src/desktop/paths.hpp

  Log Message:
  -----------
  desktop: Add functionality to enumerate paths of interest

This allows querying things such as the user's home dir, drive letters
(Windows-only), and game paths such as the data dir, preferences, user
data, and binaries. The results are presented in a format that's
suitable for UI use, with translatable labels used wherever applicable.

At some point there'll be support for listing user-defined bookmarks as
well.


  Commit: d1951b40b92d5cc4f34c8936c54f73fcc07149b1
      https://github.com/wesnoth/wesnoth/commit/d1951b40b92d5cc4f34c8936c54f73fcc07149b1
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-10-12 (Wed, 12 Oct 2016)

  Changed paths:
    M data/gui/window/file_dialog.cfg
    A images/misc/folder-bookmark-icon.png
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/file_dialog.hpp

  Log Message:
  -----------
  gui2/tfile_dialog: Add a bookmarks bar

The bookmarks bar holds predefined bookmarks (as in the stuff
src/desktop/paths.hpp exposes) and allows users to easily browse to them
in a single click. It will eventually be possible for the user to add or
remove custom bookmarks as well.

I might add a method to disable specific irrelevant bookmarks later, not
sure (e.g. nobody cares about the preferences dir when trying to find
wesnothd).


  Commit: eb3bc1f0ce88a3f2b0f0e9eace1c0b868d3d7a61
      https://github.com/wesnoth/wesnoth/commit/eb3bc1f0ce88a3f2b0f0e9eace1c0b868d3d7a61
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-10-12 (Wed, 12 Oct 2016)

  Changed paths:
    M data/gui/window/file_dialog.cfg

  Log Message:
  -----------
  gui2/tfile_dialog: Rearrange some elements

The path label above the fileview now stands on its own without the
"Location:" label since it's self-explanatory for anyone who's managed
to get this far and install Wesnoth. The Delete and New Folder buttons
have had their order reversed so that destructive actions are on the
side opposite to the dialog's control buttons (OK/Cancel), the "Places"
heading no longer has a colon.


  Commit: 71f69a8f301a0b5a09f62f53aba35047dc0030e8
      https://github.com/wesnoth/wesnoth/commit/71f69a8f301a0b5a09f62f53aba35047dc0030e8
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-10-12 (Wed, 12 Oct 2016)

  Changed paths:
    M src/desktop/paths.cpp
    M src/desktop/paths.hpp

  Log Message:
  -----------
  desktop: Add support for user-defined bookmarks

Now they are kept in a separate list using a different interface, since
otherwise it'll be harder to keep track of which bookmarks are
user-defined and which aren't, in the file dialog.


  Commit: 007a76d72fb4a41238a19e1eb7cb859973e3dd62
      https://github.com/wesnoth/wesnoth/commit/007a76d72fb4a41238a19e1eb7cb859973e3dd62
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-10-12 (Wed, 12 Oct 2016)

  Changed paths:
    M data/gui/window/file_dialog.cfg
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/file_dialog.hpp

  Log Message:
  -----------
  gui2/tfile_dialog: Add support for user-defined bookmarks

Users can add and remove bookmarks from the end of the bookmarks list.
These correspond to the currently viewed directory and have its name as
their label. It's not possible to remove hardcoded bookmarks. A bookmark
may only be removed after selecting it.

In order to ensure that users will be able to remove their own bookmarks
if they match predefined paths, the bookmarks bar now matches items from
bottom to top instead of the other way around.


  Commit: bb005cfe3c14a6623ad4fbec0b1e9046c87f6e4e
      https://github.com/wesnoth/wesnoth/commit/bb005cfe3c14a6623ad4fbec0b1e9046c87f6e4e
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-10-12 (Wed, 12 Oct 2016)

  Changed paths:
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/folder_create.cpp
    M src/gui/dialogs/folder_create.hpp

  Log Message:
  -----------
  gui2/tfile_dialog: Allow users to customize labels when bookmarking paths

We're piggybacking on the existing tfolder_create dialog with some added
functionality and a dummy tbookmark_create class for now.


Compare: https://github.com/wesnoth/wesnoth/compare/db0b20dae774...bb005cfe3c14


More information about the Commits mailing list