[Commits] [wesnoth/wesnoth] 7e84ad: Menu Button: added validation check for case where...

GitHub noreply at github.com
Sun Oct 16 05:39:44 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7e84adf348d564e2154d6af9400f4a4cdb1adf2a
      https://github.com/wesnoth/wesnoth/commit/7e84adf348d564e2154d6af9400f4a4cdb1adf2a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M src/gui/widgets/menu_button.cpp

  Log Message:
  -----------
  Menu Button: added validation check for case where dropdown returned -1 as its selected value

As mentioned in the comment, this could happen if one clicks a selection and moves their mouse away too quickly.
This simply swallows that case.


  Commit: a5350ea9f9c062327e05ffb19fdb41ae580563b0
      https://github.com/wesnoth/wesnoth/commit/a5350ea9f9c062327e05ffb19fdb41ae580563b0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp

  Log Message:
  -----------
  Menu Button: cleaned up a duplicate member

This makes the member name consistent with that used by other widgets.


Compare: https://github.com/wesnoth/wesnoth/compare/144179f694ee...a5350ea9f9c0


More information about the Commits mailing list