[Commits] [wesnoth/wesnoth] 9028a8: MP Options Helper: refactor data storage structure

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9028a8e159f31fab1cbdad094769d3d219e51ba7
      https://github.com/wesnoth/wesnoth/commit/9028a8e159f31fab1cbdad094769d3d219e51ba7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-25 (Tue, 25 Oct 2016)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.hpp

  Log Message:
  -----------
  MP Options Helper: refactor data storage structure

Firstly, this avoids creating duplicate option_source objects in both visible_options and options_data,
and instead makes use of the source id key.

Secondly, it replaces, the sub-map with a config. I don't know if it's any more efficient, but it allows
a simpler transition to option_id = value format after the GUI1 MP screens are dropped.