[Commits] [wesnoth/wesnoth] 757367: Fix crash on placing a unit with the scenario edit...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7573678201483dbfd19a1950c0edfec4487dc19e
      https://github.com/wesnoth/wesnoth/commit/7573678201483dbfd19a1950c0edfec4487dc19e
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/actions/create.cpp
    M src/actions/heal.cpp
    M src/actions/move.cpp
    M src/actions/vision.cpp
    M src/ai/composite/goal.cpp
    M src/ai/contexts.cpp
    M src/ai/default/aspect_attacks.cpp
    M src/ai/default/ca.cpp
    M src/ai/default/contexts.cpp
    M src/ai/formula/callable_objects.cpp
    M src/ai/formula/candidates.cpp
    M src/display.cpp
    M src/display_context.cpp
    M src/game_board.cpp
    M src/gui/dialogs/unit_list.cpp
    M src/menu_events.cpp
    M src/mouse_events.cpp
    M src/pathfind/pathfind.cpp
    M src/pathfind/teleport.cpp
    M src/play_controller.cpp
    M src/reports.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/game_lua_kernel.hpp
    M src/tod_manager.cpp
    M src/units/abilities.cpp
    M src/units/drawer.cpp
    M src/units/filter.cpp
    M src/units/udisplay.cpp
    M src/units/unit.cpp
    M src/units/unit.hpp
    M src/whiteboard/mapbuilder.cpp

  Log Message:
  -----------
  Fix crash on placing a unit with the scenario editor

The unit::get_ability_bool() function accessed resources::gameboard that
is not set in the editor. Now the function receives the display context
as a parameter instead.

I also fixed two crashes on editor startup in MSVC debug builds (both
caused by indexing the teams vector when there aren't any teams), and the
GUI2 unit list dialog showing wrong status icons.


  Commit: e82fc498acd7778971bc64ebf1561c2244465152
      https://github.com/wesnoth/wesnoth/commit/e82fc498acd7778971bc64ebf1561c2244465152
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/actions/create.cpp
    M src/actions/heal.cpp
    M src/actions/vision.cpp
    M src/display_context.cpp
    M src/game_board.cpp
    M src/mouse_events.cpp
    M src/units/drawer.cpp
    M src/units/unit.cpp
    M src/units/unit.hpp
    M src/whiteboard/mapbuilder.cpp

  Log Message:
  -----------
  Remove the map parameter from the unit::is_visible_to_team() function

Now when the function receives the entire display_context and can get the
map from there, passing the map separately is unnecessary.


  Commit: bda24b3f938c84a75c1fca3372da6ba9f95ced1d
      https://github.com/wesnoth/wesnoth/commit/bda24b3f938c84a75c1fca3372da6ba9f95ced1d
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M src/actions/create.cpp
    M src/actions/heal.cpp
    M src/actions/move.cpp
    M src/actions/vision.cpp
    M src/ai/composite/goal.cpp
    M src/ai/contexts.cpp
    M src/ai/default/aspect_attacks.cpp
    M src/ai/default/ca.cpp
    M src/ai/default/contexts.cpp
    M src/ai/formula/callable_objects.cpp
    M src/ai/formula/candidates.cpp
    M src/display.cpp
    M src/display_context.cpp
    M src/game_board.cpp
    M src/gui/dialogs/unit_list.cpp
    M src/menu_events.cpp
    M src/mouse_events.cpp
    M src/pathfind/pathfind.cpp
    M src/pathfind/teleport.cpp
    M src/play_controller.cpp
    M src/reports.cpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/game_lua_kernel.hpp
    M src/tod_manager.cpp
    M src/units/abilities.cpp
    M src/units/drawer.cpp
    M src/units/filter.cpp
    M src/units/udisplay.cpp
    M src/units/unit.cpp
    M src/units/unit.hpp
    M src/whiteboard/mapbuilder.cpp

  Log Message:
  -----------
  Merge pull request #760 from jyrkive/editor-crashes

Fix crash on placing a unit with the scenario editor


Compare: https://github.com/wesnoth/wesnoth/compare/f97dc8ae12be...bda24b3f938c