[Commits] [wesnoth/wesnoth] f50c7d: Revert "Work around unit halo not disappearing wit...

GitHub noreply at github.com
Thu Dec 28 10:02:46 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f50c7d3f2aab698487cd68c2dda408d7ffa27ee2
      https://github.com/wesnoth/wesnoth/commit/f50c7d3f2aab698487cd68c2dda408d7ffa27ee2
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M data/lua/wml/kill.lua

  Log Message:
  -----------
  Revert "Work around unit halo not disappearing with [kill] animate=yes"

This reverts commit 70b468070b71616aa3663088b6ad171391d0c4f0.

As I said in the commit message, the fix is not pretty, and
@CelticMinstrel said in IRC that a different fix would definitely be
better. I'll fix the problem by having an animation automatically
release the unit when done, instead (next commit).


  Commit: d81f2306806e35507d9de27bcf7d24e39bfc0d91
      https://github.com/wesnoth/wesnoth/commit/d81f2306806e35507d9de27bcf7d24e39bfc0d91
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-12-28 (Thu, 28 Dec 2017)

  Changed paths:
    M data/lua/wml/kill.lua

  Log Message:
  -----------
  Clear unit death animation after killing the unit

This is another and much better way to fix the unit halo remaining.


Compare: https://github.com/wesnoth/wesnoth/compare/1c2968c632bc...d81f2306806e


More information about the Commits mailing list