[Commits] [wesnoth/wesnoth] 789fcb: Revert "Simple Item Selector: disable Esc cancelin...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 789fcb6f90c69cea25353b369997f5fe1b3bd44b
      https://github.com/wesnoth/wesnoth/commit/789fcb6f90c69cea25353b369997f5fe1b3bd44b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-02-24 (Fri, 24 Feb 2017)

  Changed paths:
    M src/gui/dialogs/simple_item_selector.cpp

  Log Message:
  -----------
  Revert "Simple Item Selector: disable Esc canceling if single button mode is enabled"

This reverts commit bd47e75d32e07a29c204ceb71dd7a837486ad73a.


  Commit: 0474c2eb1f7e05942ff0b1abf45290e672cfb93d
      https://github.com/wesnoth/wesnoth/commit/0474c2eb1f7e05942ff0b1abf45290e672cfb93d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-02-24 (Fri, 24 Feb 2017)

  Changed paths:
    M src/gui/dialogs/simple_item_selector.cpp

  Log Message:
  -----------
  Simple Item Selector: save selected index even on cancel

This is a better fix for bug #25536 since it allows easy bypassing of the dialog with Esc if single button
mode was enabled, but without crashing. Usecases can stil explicitly check for the dialog retval for conditional
behavior.


Compare: https://github.com/wesnoth/wesnoth/compare/bd47e75d32e0...0474c2eb1f7e