[Commits] [wesnoth/wesnoth] 9c18a4: Revert "Quell divide-by-zero warning"

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9c18a44f526a326de9dd5a6b9fc6ecea8e58ccf5
      https://github.com/wesnoth/wesnoth/commit/9c18a44f526a326de9dd5a6b9fc6ecea8e58ccf5
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-01 (Wed, 01 Nov 2017)

  Changed paths:
    M src/sdl/utils.cpp

  Log Message:
  -----------
  Revert "Quell divide-by-zero warning"

This reverts commit 07b04775ff3995fca279b15750860f5e79ae2f63.

This code is performance-critical: adding a branch for every pixel in
the surface isn't a good idea. @GregoryLundberg was fine with reverting
the commit, as well. The same is true for the next two reverts.

Fixing Coverity Scan warnings is good and all, but we shouldn't
sacrifice performance for it.


  Commit: 911411a1a8de11de609366f33a9d94b4b4a622d5
      https://github.com/wesnoth/wesnoth/commit/911411a1a8de11de609366f33a9d94b4b4a622d5
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-01 (Wed, 01 Nov 2017)

  Changed paths:
    M src/sdl/utils.cpp

  Log Message:
  -----------
  Revert "add an assert to detect possible division by zero"

This reverts commit 968d8a900dc2af7cf0b2a023b5a49d84a52e470d.


  Commit: 61bbd51f3a2ad0302945c722e040171976193518
      https://github.com/wesnoth/wesnoth/commit/61bbd51f3a2ad0302945c722e040171976193518
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-01 (Wed, 01 Nov 2017)

  Changed paths:
    M src/pathfind/pathfind.cpp

  Log Message:
  -----------
  Revert "Quell CID 1380157"

This reverts commit 37ac4414b9e8ec1458e46b96b6564e15c7eb63ac.


Compare: https://github.com/wesnoth/wesnoth/compare/631acb2bb881...61bbd51f3a2a