[Commits] [wesnoth/wesnoth] 50c9b5: Refactor MP connection code to avoid constantly cr...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 50c9b526a7abbf6afa1612cc7c7e9caac2a3ef8c
      https://github.com/wesnoth/wesnoth/commit/50c9b526a7abbf6afa1612cc7c7e9caac2a3ef8c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-07 (Tue, 07 Nov 2017)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/network_transmission.cpp
    M src/gui/dialogs/network_transmission.hpp

  Log Message:
  -----------
  Refactor MP connection code to avoid constantly creating loading screens

Previously, the use of the wesnothd_connect_dialog and wesnothd_receive_dialog wrappers meant
multiple loading screen instances were created when connecting to MP. This change means only
one (or two, if the config is reloaded) loading screen objects are created when connecting to
the server. It also ensures the entire connection process (ie, the extent of open_connection)
is done with a loading screen displayed.