[Commits] [wesnoth/wesnoth] 2c12d1: Game Events: fixed a few oversights in 056d7ac8f88...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2c12d1328ba6fc6c45f5b7ed0eafac656ef53d65
      https://github.com/wesnoth/wesnoth/commit/2c12d1328ba6fc6c45f5b7ed0eafac656ef53d65
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-30 (Thu, 30 Nov 2017)

  Changed paths:
    M src/game_events/handlers.cpp
    M src/game_events/manager_impl.cpp

  Log Message:
  -----------
  Game Events: fixed a few oversights in 056d7ac8f88c

* Fixed assertion failure when removing single-use custom events. Not actually something
  broken, I just forgot to add a "not already disabled" check when doing so since I added
  that assertion in event_handler::disable.
* Added a message to the aforementioned assertion.
* Ensure handler cleanup actually happens when removing custom events.
* Account for events with multiple names in cleanup.


  Commit: fb5fd3f3c4788c11826dd92a36b601e9e4929014
      https://github.com/wesnoth/wesnoth/commit/fb5fd3f3c4788c11826dd92a36b601e9e4929014
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-30 (Thu, 30 Nov 2017)

  Changed paths:
    M src/game_events/manager_impl.cpp

  Log Message:
  -----------
  Game Events: made use of some emplace_back when constructing handlers

And added a clarifying comment about types.


Compare: https://github.com/wesnoth/wesnoth/compare/3f646cc96547...fb5fd3f3c478