[wesnoth-commits] [wesnoth/wesnoth] 23e78a: Help: massive refactor and cleanup of the help bac...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 23e78abb20b00786ad58bbefda08904742974f8e
      https://github.com/wesnoth/wesnoth/commit/23e78abb20b00786ad58bbefda08904742974f8e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M data/gui/window/help_browser.cfg
    M projectfiles/VC14/wesnoth.vcxproj
    M projectfiles/VC14/wesnoth.vcxproj.filters
    M source_lists/wesnoth
    M src/editor/controller/editor_controller.cpp
    M src/gui/dialogs/help_browser.cpp
    M src/gui/dialogs/help_browser.hpp
    M src/gui/widgets/unit_preview_pane.cpp
    A src/help/constants.cpp
    A src/help/constants.hpp
    M src/help/help.cpp
    M src/help/help.hpp
    R src/help/help_topic_generators.cpp
    A src/help/manager.cpp
    A src/help/manager.hpp
    A src/help/section.cpp
    A src/help/section.hpp
    A src/help/section_generators.cpp
    A src/help/section_generators.hpp
    A src/help/topic.cpp
    A src/help/topic.hpp
    A src/help/topic_generators.cpp
    A src/help/topic_generators.hpp
    A src/help/topic_text_generators.cpp
    A src/help/topic_text_generators.hpp
    A src/help/utils.cpp
    A src/help/utils.hpp
    M src/play_controller.cpp

  Log Message:
  -----------
  Help: massive refactor and cleanup of the help backend

This basically splits all the stuff in help/help_impl.*pp into multiple files by their
function, and refactors the entire workflow into a proper object-oriented interface in
modern C++.

There are still a features missing (such as hidden section parsing in the manager) that
I'll get back to.

Few incidental changes and fixes:
* Terrain topics now sorted alphabetically.
* Help text now small
* Fixed wrong toggle button id in browser. This is what was making it impossible to expand
  any sections.

The GUI2 help browser is now back in working order, inasmuch as you can view all sections'
and topics' text (save units').