[wesnoth-commits] [wesnoth/wesnoth] 26b6ca: Fixed crash when starting the editor (fixes #2816)

GitHub noreply at github.com
Tue Apr 3 02:53:47 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 26b6ca54bb0a53ee56f74a23cb9818b08794356d
      https://github.com/wesnoth/wesnoth/commit/26b6ca54bb0a53ee56f74a23cb9818b08794356d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M src/display.cpp

  Log Message:
  -----------
  Fixed crash when starting the editor (fixes #2816)

If no display_context was passed to the display ctor (such as is the case in the editor),
the terrain_builder's gamemap pointer would be null. Really not sure why this didn't cause
a crash n the 1.14 branch, but oh well.

I just removed the ctor call to rebuild_all() since it's not really needed. The map is
rebuilt when change_display_context is called anyway, which both the editor_controller and
play_controller do.




More information about the Commits mailing list