[wesnoth-commits] [wesnoth/wesnoth] c7028a: TB: Fix errors found by schema validator

[GitHub]

  Branch: refs/heads/schema_fixes
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c7028aadff3526723d3352d694b013510c32564d
      https://github.com/wesnoth/wesnoth/commit/c7028aadff3526723d3352d694b013510c32564d
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/campaigns/Two_Brothers/scenarios/01_Rooting_Out_a_Mage.cfg
    M data/campaigns/Two_Brothers/scenarios/02_The_Chase.cfg

  Log Message:
  -----------
  TB: Fix errors found by schema validator

- Passing () as the side to the unit util macros results in an empty side key
  There's no reason not to just pass 1 instead though.
- [modify_side] does not support [filter]; instead it uses [filter_side]
  However, it also supports inline side which is sufficient here,
  so just use that instead.

This covers both difficulty levels; TB is now clean of schema issues.


  Commit: 50f52e761f9f5e8d15adee462ff8719fa97dc6d4
      https://github.com/wesnoth/wesnoth/commit/50f52e761f9f5e8d15adee462ff8719fa97dc6d4
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/campaigns/An_Orcish_Incursion/scenarios/02_Assassins.cfg
    M data/campaigns/An_Orcish_Incursion/scenarios/04_Valley_of_Trolls.cfg

  Log Message:
  -----------
  AOI: Fix errors found by schema validator

- grouping=no, not grouping=none
- speaker is a message key not a filter key

With this, AOI is clean of schema issues.


  Commit: 6d6dcd0199c30f586a03dd1da10b42b108e73956
      https://github.com/wesnoth/wesnoth/commit/6d6dcd0199c30f586a03dd1da10b42b108e73956
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/core/macros/unit-utils.cfg

  Log Message:
  -----------
  Remove animate=no from {GUARDIAN}

This is the default in [unit] anyway, and if the user specified
animate=yes explicitly then we should not override that.


  Commit: 9a87667c84ccf850c224f6479b34a8d93ac1b643
      https://github.com/wesnoth/wesnoth/commit/9a87667c84ccf850c224f6479b34a8d93ac1b643
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg
    M data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg
    M data/campaigns/The_South_Guard/scenarios/06b_The_Long_March.cfg

  Log Message:
  -----------
  TSG: Fix errors found by schema validator

With this, TSG is now clean of schema issues


  Commit: 1b1fca2039540945cea43d13be0b59c7a2f72b90
      https://github.com/wesnoth/wesnoth/commit/1b1fca2039540945cea43d13be0b59c7a2f72b90
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/units/Battle_Princess.cfg
    M data/campaigns/Heir_To_The_Throne/units/Commander.cfg
    M data/campaigns/Heir_To_The_Throne/units/Fighter.cfg
    M data/campaigns/Heir_To_The_Throne/units/Lord.cfg
    M data/campaigns/Heir_To_The_Throne/units/Princess.cfg

  Log Message:
  -----------
  HTTT: Unit variations don't need an ID


  Commit: 9d7a177470f6035f39dddb2f05e3ae82be43e18f
      https://github.com/wesnoth/wesnoth/commit/9d7a177470f6035f39dddb2f05e3ae82be43e18f
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/core/macros/items.cfg

  Log Message:
  -----------
  [effect]apply_to=new_animation does not support name

It does support id though, which is used as a sort of caching mechanism
in case the same effect is applied many times, so use that instead of name.
For good measure, also use an id on the sceptre of fire animation


  Commit: 74ba431bfd7c985741a1150bc818fb1dc1c88f12
      https://github.com/wesnoth/wesnoth/commit/74ba431bfd7c985741a1150bc818fb1dc1c88f12
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-04 (Wed, 04 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/09_The_Valley_of_Death.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg

  Log Message:
  -----------
  HTTT: Fix errors found by schema validator

This fixes most of the errors, but there still a few more to squelch.


Compare: https://github.com/wesnoth/wesnoth/compare/097622c13da0...74ba431bfd7c