[wesnoth-commits] [wesnoth/wesnoth] 120e6e: Fix erroneous/useless [event] in [titlescreen_musi...

GitHub noreply at github.com
Sun Apr 8 13:58:14 UTC 2018


  Branch: refs/heads/schema_fixes
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 120e6e5e5f6684d6c4def4463deb2ac64cbf1e99
      https://github.com/wesnoth/wesnoth/commit/120e6e5e5f6684d6c4def4463deb2ac64cbf1e99
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/core/editor/_main.cfg
    M data/core/editor/music.cfg
    M data/core/macros/sound-utils.cfg
    M data/multiplayer/_main.cfg

  Log Message:
  -----------
  Fix erroneous/useless [event] in [titlescreen_music], [lobby_music], [editor_music]

The playlist macros set the music list twice, once before the
story screen and again in prestart, but the order of tracks is different.

This means that the track order at the titlescreen and in the lobby is now the same
as the track order in a scenario using the default playlist, which previously was not the case.

Similarly, the track order in the editor is now the same as the track order
in a scenario using the full playlist.

Whether that actually matters? I have no idea. I doubt it.

In any case, as of this commit, there are no schema validation errors
at the title screen, when entering the MP Create screen, or in the map editor.


  Commit: b3c98424bacc7d4e04832156872c865952182828
      https://github.com/wesnoth/wesnoth/commit/b3c98424bacc7d4e04832156872c865952182828
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/ai/micro_ais/scenarios/The_Elves_Besieged.cfg
    M data/ai/micro_ais/scenarios/animals.cfg
    M data/ai/micro_ais/scenarios/bottleneck_defense.cfg
    M data/ai/micro_ais/scenarios/dragon.cfg
    M data/ai/micro_ais/scenarios/fast.cfg
    M data/ai/micro_ais/scenarios/goto.cfg
    M data/ai/micro_ais/scenarios/guardians.cfg
    M data/ai/micro_ais/scenarios/hang_out.cfg
    M data/ai/micro_ais/scenarios/healer_support.cfg
    M data/ai/micro_ais/scenarios/lurkers.cfg
    M data/ai/micro_ais/scenarios/messenger_escort.cfg
    M data/ai/micro_ais/scenarios/patrols.cfg
    M data/ai/micro_ais/scenarios/protect_unit.cfg
    M data/ai/micro_ais/scenarios/recruiting.cfg
    M data/ai/micro_ais/scenarios/scenario_micro_ai.cfg
    M data/ai/micro_ais/scenarios/simple_attack.cfg
    M data/ai/micro_ais/scenarios/swarm.cfg
    M data/ai/micro_ais/scenarios/wolves.cfg
    M data/ai/scenarios/scenario-AI_Arena_small.cfg
    M data/ai/scenarios/scenario-high_xp_attack.cfg
    M data/campaigns/Dead_Water/scenarios/08_Talking_to_Tyegea.cfg
    M data/campaigns/Dead_Water/scenarios/11_Getting_Help.cfg
    M data/campaigns/Dead_Water/scenarios/12_Revenge.cfg
    M data/campaigns/Dead_Water/scenarios/13_Epilogue.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/16_Dark_Sky_Over_Weldyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/23_Epilogue.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/12_Endless_Night.cfg
    M data/campaigns/Eastern_Invasion/scenarios/08_Training_the_Ogres.cfg
    M data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg
    M data/campaigns/Eastern_Invasion/scenarios/17a_The_Duel.cfg
    M data/campaigns/Eastern_Invasion/scenarios/17b_Weldyn_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/14_Plunging_Into_the_Darkness.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg
    M data/campaigns/Northern_Rebirth/scenarios/14a_Epilogue.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/9_Caverns_of_Flame.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/09_Training_Session.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/21_Against_the_World.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/22_Epilogue.cfg
    M data/campaigns/Son_Of_The_Black_Eye/scenarios/18_Northern_Alliance.cfg
    M data/campaigns/Son_Of_The_Black_Eye/scenarios/19_Epilogue.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/02_Reclaiming_the_Past.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/13_Epilogue.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/15_A_New_Land.cfg
    M data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg
    M data/campaigns/The_South_Guard/scenarios/09a_Vengeance.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07b_Talking_with_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/13_Epilogue.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios_old/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios_old/07b_Talking_with_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios_old/13_Epilogue.cfg
    M data/multiplayer/scenarios/2p_Dark_Forecast.cfg
    M data/scenario-leaders.cfg
    M data/scenario-movethrough.cfg
    M data/scenario-test.cfg

  Log Message:
  -----------
  Embrace turns=unlimited as a way of specifying unlimited turns


  Commit: 69de647501c7242ddbc42dc53c4aa1b775edf802
      https://github.com/wesnoth/wesnoth/commit/69de647501c7242ddbc42dc53c4aa1b775edf802
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/multiplayer/scenarios/ANL_utils/ANL_general_macros.cfg
    M data/multiplayer/scenarios/ANL_utils/ANL_special_macros.cfg

  Log Message:
  -----------
  ANL: Remove needless silent= key from [object]s

The silent key is meaningful only when using the [object] as ActionWML.
None of these are used thusly, so it does nothing.


  Commit: 4dc25f6edb791e1aac123639d54ebb2e245c4399
      https://github.com/wesnoth/wesnoth/commit/4dc25f6edb791e1aac123639d54ebb2e245c4399
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/01_The_Uprooting.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/02_Hostile_Mountains.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/03_Kalian_under_Attack.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/04_The_Elvish_Treasury.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/05_The_Saurian_Treasury.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/06_Acquaintance_in_Need.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter5/22_Northern_Battle.cfg

  Log Message:
  -----------
  LoW: Remove redundant AI definitions

These are used by default, so there's no need to specifically include them.


  Commit: a05dd4b4e70f8aeb9a120ea49b95d3e74dc7bd23
      https://github.com/wesnoth/wesnoth/commit/a05dd4b4e70f8aeb9a120ea49b95d3e74dc7bd23
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg

  Log Message:
  -----------
  LoW7: Fix invalid use of aspects in [unit][ai]

This doesn't quite produce what is presumed to be the intended result.
It does at least preserve the differing recruitment patterns though.

Includes the following recommendations from mattsc:

- Drop {AI_NO_SCOUTS} since the recruitment pattern contradicts it
- Drop attack_depth and grouping
- Keep the night-only aggression and caution change, even for the nagas


  Commit: 325c685446f89370fdc33d490dad2aca2d7caa73
      https://github.com/wesnoth/wesnoth/commit/325c685446f89370fdc33d490dad2aca2d7caa73
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/utils/characters.cfg

  Log Message:
  -----------
  LoW: Fix erroneous used of unrenamable and canrecruit keys in [side] when there is no unit


  Commit: 1f04c887ccc41ed296b8b20030b4f83e2cfcf52b
      https://github.com/wesnoth/wesnoth/commit/1f04c887ccc41ed296b8b20030b4f83e2cfcf52b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/core/macros/ai_controller.cfg

  Log Message:
  -----------
  Fix error in AI control core macros


  Commit: ab6ee508138d31e6bc4d27bd8248b3029128cc01
      https://github.com/wesnoth/wesnoth/commit/ab6ee508138d31e6bc4d27bd8248b3029128cc01
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/08_Council_of_Hard_Choices.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter3/09_Bounty_Hunters.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/16_The_Chief_Must_Die.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/17_Breaking_the_Siege.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter5/21_Elvish_Assassins.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter5/23_End_of_War.cfg
    M data/campaigns/Legend_of_Wesmere/utils/characters.cfg

  Log Message:
  -----------
  LoW: Several small fixes (misplaced keys mostly)


  Commit: ea54c2a897cdd7e521c55ad7d63e670bd04590ea
      https://github.com/wesnoth/wesnoth/commit/ea54c2a897cdd7e521c55ad7d63e670bd04590ea
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Two_Brothers/scenarios/01_Rooting_Out_a_Mage.cfg
    M data/campaigns/Two_Brothers/scenarios/02_The_Chase.cfg

  Log Message:
  -----------
  TB: Fix errors found by schema validator

- Passing () as the side to the unit util macros results in an empty side key
  There's no reason not to just pass 1 instead though.
- [modify_side] does not support [filter]; instead it uses [filter_side]
  However, it also supports inline side which is sufficient here,
  so just use that instead.

This covers both difficulty levels; TB is now clean of schema issues.


  Commit: a03be65bb56e5b7b029dbb2ad390a2f0942ef1b1
      https://github.com/wesnoth/wesnoth/commit/a03be65bb56e5b7b029dbb2ad390a2f0942ef1b1
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/An_Orcish_Incursion/scenarios/02_Assassins.cfg
    M data/campaigns/An_Orcish_Incursion/scenarios/04_Valley_of_Trolls.cfg

  Log Message:
  -----------
  AOI: Fix errors found by schema validator

- grouping=no, not grouping=none
- speaker is a message key not a filter key

With this, AOI is clean of schema issues.


  Commit: 58216b3aaf3643be2fe2cf782bfbe749cbb7cdc7
      https://github.com/wesnoth/wesnoth/commit/58216b3aaf3643be2fe2cf782bfbe749cbb7cdc7
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/core/macros/unit-utils.cfg

  Log Message:
  -----------
  Remove animate=no from {GUARDIAN}

This is the default in [unit] anyway, and if the user specified
animate=yes explicitly then we should not override that.


  Commit: e1ed3731fe4ad3a90dbdb81b6c967fe02b6e6f55
      https://github.com/wesnoth/wesnoth/commit/e1ed3731fe4ad3a90dbdb81b6c967fe02b6e6f55
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg
    M data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg
    M data/campaigns/The_South_Guard/scenarios/06b_The_Long_March.cfg

  Log Message:
  -----------
  TSG: Fix errors found by schema validator

With this, TSG is now clean of schema issues


  Commit: bab810c57ab38398718b89caf068fb3fd4aecdb3
      https://github.com/wesnoth/wesnoth/commit/bab810c57ab38398718b89caf068fb3fd4aecdb3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/units/Battle_Princess.cfg
    M data/campaigns/Heir_To_The_Throne/units/Commander.cfg
    M data/campaigns/Heir_To_The_Throne/units/Fighter.cfg
    M data/campaigns/Heir_To_The_Throne/units/Lord.cfg
    M data/campaigns/Heir_To_The_Throne/units/Princess.cfg

  Log Message:
  -----------
  HTTT: Unit variations don't need an ID


  Commit: dd08e03d64c08251815e08adf4677cc8abd285e3
      https://github.com/wesnoth/wesnoth/commit/dd08e03d64c08251815e08adf4677cc8abd285e3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/core/macros/items.cfg

  Log Message:
  -----------
  [effect]apply_to=new_animation does not support name

It does support id though, which is used as a sort of caching mechanism
in case the same effect is applied many times, so use that instead of name.
For good measure, also use an id on the sceptre of fire animation


  Commit: 1440beaa7fa650c64d4d7179fdd87704c9693fe7
      https://github.com/wesnoth/wesnoth/commit/1440beaa7fa650c64d4d7179fdd87704c9693fe7
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/09_The_Valley_of_Death.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg

  Log Message:
  -----------
  HTTT: Fix errors found by schema validator

This fixes most of the errors, but there still a few more to squelch.


  Commit: 6da61d87e1b5a5a0c8c7fb9f93b1409972e81fdb
      https://github.com/wesnoth/wesnoth/commit/6da61d87e1b5a5a0c8c7fb9f93b1409972e81fdb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Eastern_Invasion/scenarios/07a_The_Crossing.cfg
    M data/campaigns/Eastern_Invasion/scenarios/07b_Undead_Crossing.cfg
    M data/campaigns/Eastern_Invasion/scenarios/09_Xenophobia.cfg
    M data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg
    M data/campaigns/Eastern_Invasion/scenarios/17a_The_Duel.cfg

  Log Message:
  -----------
  EI: Fix issues found by the schema validator

With this, EI is as clean of schema errors as it's going to get.
There yet remain a number of unsolvable schema errors (due to multi-use macros).

Regarding {LOYAL_UNIT}, specifying the side here is redundant;
however, an empty side key raises an error, and it doesn't hurt
to specify the redundant information.


  Commit: b7f6d7ee0ef427fa206277e21a051b2ad7092ceb
      https://github.com/wesnoth/wesnoth/commit/b7f6d7ee0ef427fa206277e21a051b2ad7092ceb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg

  Log Message:
  -----------
  HoT: Fix issues found by the schema validator

With this, HoT is clean of schema errors


  Commit: ffb7be165af60f689a90335ca6ae4189ddfef434
      https://github.com/wesnoth/wesnoth/commit/ffb7be165af60f689a90335ca6ae4189ddfef434
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Descent_Into_Darkness/scenarios/01_Saving_Parthyn.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/03_A_Haunting_in_Winter.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/09_A_Small_Favor3.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/10_Alone_at_Last.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg

  Log Message:
  -----------
  DiD: Fix issues found by the schema validator

With this, DiD is now clean of schema errors


  Commit: 72507af3fd46479247c1e00e2890438ecbcf9a5a
      https://github.com/wesnoth/wesnoth/commit/72507af3fd46479247c1e00e2890438ecbcf9a5a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg

  Log Message:
  -----------
  DM: Fix issues found by the schema validator

With this, DM is now clean of schema errors


  Commit: 13a66015fe87f85d9b60b02145fe670362801607
      https://github.com/wesnoth/wesnoth/commit/13a66015fe87f85d9b60b02145fe670362801607
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Dead_Water/scenarios/01_Invasion.cfg
    M data/campaigns/Dead_Water/scenarios/04_Slavers.cfg

  Log Message:
  -----------
  DW: Remove [message]duration key since it does absolutely nothing


  Commit: 0c2c34693f6cae230185b12abdecb6390f8fe491
      https://github.com/wesnoth/wesnoth/commit/0c2c34693f6cae230185b12abdecb6390f8fe491
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg

  Log Message:
  -----------
  DW: Fix a couple more issues found by the schema validator

With this, DW is clean of schema errors


  Commit: 58f527cff3ac49861233025c8da7288caff5bcaf
      https://github.com/wesnoth/wesnoth/commit/58f527cff3ac49861233025c8da7288caff5bcaf
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/maps/02_Dark_Business.map
    M data/campaigns/Secrets_of_the_Ancients/maps/03_Bandits.map
    M data/campaigns/Secrets_of_the_Ancients/maps/04_Becalmed.map
    M data/campaigns/Secrets_of_the_Ancients/maps/06_Following_the_Shadow.map
    M data/campaigns/Secrets_of_the_Ancients/maps/07_Meeting_of_the_Minds.map
    M data/campaigns/Secrets_of_the_Ancients/maps/08_Carcyn.map
    M data/campaigns/Secrets_of_the_Ancients/maps/09_Training_Session.map
    M data/campaigns/Secrets_of_the_Ancients/maps/11_Battleground.map
    M data/campaigns/Secrets_of_the_Ancients/maps/12_Walking_Trees.map
    M data/campaigns/Secrets_of_the_Ancients/maps/13_Together_Again.map
    M data/campaigns/Secrets_of_the_Ancients/maps/14_Entering_the_Northlands.map
    M data/campaigns/Secrets_of_the_Ancients/maps/15_Mountain_Pass.map
    M data/campaigns/Secrets_of_the_Ancients/maps/16_The_Mage.map
    M data/campaigns/Secrets_of_the_Ancients/maps/17_Mortality.map
    M data/campaigns/Secrets_of_the_Ancients/maps/18_Abandoned_Outpost.map
    M data/campaigns/Secrets_of_the_Ancients/maps/19_Lava_and_Stone.map

  Log Message:
  -----------
  SotA: Remove obsolete map headers


  Commit: 08f1d063b31f3e49705c1fdd43710aebbb0604ec
      https://github.com/wesnoth/wesnoth/commit/08f1d063b31f3e49705c1fdd43710aebbb0604ec
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/02_Dark_Business.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/05_Blackwater.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/20_North_Knalga.cfg
    M data/campaigns/Secrets_of_the_Ancients/utils/sota-utils.cfg

  Log Message:
  -----------
  SotA: Remove weird terrain='' convention

The wiki proscribes terrain=^ for this purpose, which has the bonus
of being detected as a valid terrain code by the schema.


  Commit: 1538670928cbb66fb63d90a735a8b2a2aaeaeaf9
      https://github.com/wesnoth/wesnoth/commit/1538670928cbb66fb63d90a735a8b2a2aaeaeaf9
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/06_Following_the_Shadow.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/07_Meeting_of_the_Minds.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/15_Mountain_Pass.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/21_Against_the_World.cfg

  Log Message:
  -----------
  SotA: Fix a few more issues found by the schema validator

With this, SotA is now clean of schema errors


  Commit: 3301e489f7ffea2cf3df68886b9fc075f2c20fb6
      https://github.com/wesnoth/wesnoth/commit/3301e489f7ffea2cf3df68886b9fc075f2c20fb6
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Sceptre_of_Fire/scenarios/1_A_Bargain_is_Struck.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/9_Caverns_of_Flame.cfg

  Log Message:
  -----------
  SoF: Fix issues found by the schema validator


  Commit: aefaefe6f4395091b7a1a878c59b193f8b679895
      https://github.com/wesnoth/wesnoth/commit/aefaefe6f4395091b7a1a878c59b193f8b679895
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg

  Log Message:
  -----------
  NR: usage= and alignment= not supported in SUF


  Commit: b8008885fe51cfea28ab507f8e2d093a805fa4a4
      https://github.com/wesnoth/wesnoth/commit/b8008885fe51cfea28ab507f8e2d093a805fa4a4
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/02_01_Infested_Caves.cfg
    M data/campaigns/Northern_Rebirth/scenarios/02_02_Meeting_With_Dwarves.cfg
    M data/campaigns/Northern_Rebirth/scenarios/04_Clearing_the_Mines.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_02_Dealings.cfg
    M data/campaigns/Northern_Rebirth/scenarios/07a_Settling_Disputes.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09a_Introductions.cfg
    M data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg

  Log Message:
  -----------
  NR: Explicitly specify redundant side parameter in unit macros


  Commit: 533409f3d5ab707183bbcac9f67b213f7e38b2ed
      https://github.com/wesnoth/wesnoth/commit/533409f3d5ab707183bbcac9f67b213f7e38b2ed
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg

  Log Message:
  -----------
  NR: [ai]villages_per_scout= is an integer


  Commit: 322e6105299cc7444240b0909d569b1fdef12c22
      https://github.com/wesnoth/wesnoth/commit/322e6105299cc7444240b0909d569b1fdef12c22
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/12a_Get_the_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg

  Log Message:
  -----------
  NR: [store_unit] does not support fire_event


  Commit: d1f8a8ec2b60a7738bccbf429a7c16a8a53ff802
      https://github.com/wesnoth/wesnoth/commit/d1f8a8ec2b60a7738bccbf429a7c16a8a53ff802
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/01_Breaking_the_Chains.cfg
    M data/campaigns/Northern_Rebirth/scenarios/06a_Old_Friend.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg
    M data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg

  Log Message:
  -----------
  NR: Fix a few more issues found by the schema validator

With this, NR is clean of schema issues


  Commit: b60c6c4631e85a12528a6b4a3567e55ad63f2c26
      https://github.com/wesnoth/wesnoth/commit/b60c6c4631e85a12528a6b4a3567e55ad63f2c26
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/01_The_Morning_After.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/02_Across_the_Harsh_Sands.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg

  Log Message:
  -----------
  UtBS: [objectives] does not support show=


  Commit: 755714430f7ce6c59ab869e0cce6f13de619e80b
      https://github.com/wesnoth/wesnoth/commit/755714430f7ce6c59ab869e0cce6f13de619e80b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/04_Descending_into_Darkness.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07b_Talking_with_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/11_Battle_for_Zocthanol_Isle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/13_Epilogue.cfg

  Log Message:
  -----------
  UtBS: [scenario]snapshot= doesn't seem like it would have any useful effect

(It's probably technically valid, as this key is part of the savegame WML.)


  Commit: e951d2279af94cdfc334089b276156a0cfd5de2e
      https://github.com/wesnoth/wesnoth/commit/e951d2279af94cdfc334089b276156a0cfd5de2e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/06a_In_the_Tunnels_of_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg

  Log Message:
  -----------
  UtBS: silent= is meaningless in [object][modifications]


  Commit: 66728dfd1ea5d11b2feb66196dd81bdd1872a4f3
      https://github.com/wesnoth/wesnoth/commit/66728dfd1ea5d11b2feb66196dd81bdd1872a4f3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg

  Log Message:
  -----------
  UtBS: Fix a few more issues found by the schema validator

With this, UtBS is as clean of schema errors as it'll get
(There are still two spurious errors remaining)


  Commit: 885a22f2aca01a0328b451fbd36db110d408ab0b
      https://github.com/wesnoth/wesnoth/commit/885a22f2aca01a0328b451fbd36db110d408ab0b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/21_The_Plan.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/23_Epilogue.cfg

  Log Message:
  -----------
  TRoW: Fix a couple of issues found by the schema validator


  Commit: ba833c4b2fbd98578006c1c45abe6d5e2b17abac
      https://github.com/wesnoth/wesnoth/commit/ba833c4b2fbd98578006c1c45abe6d5e2b17abac
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/utils/intro.cfg

  Log Message:
  -----------
  HTTT: Fix toplevel [story]


  Commit: 52f96091d6b2bdb4895424cd04b4229f21685aff
      https://github.com/wesnoth/wesnoth/commit/52f96091d6b2bdb4895424cd04b4229f21685aff
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04a_The_Swamp_of_Esten.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04b_The_Midlands.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/11_Southbay_in_Winter.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/12_A_Final_Spring.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/13_Peoples_in_Decline.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/14_Rough_Landing.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/15_A_New_Land.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17a_The_Dragon.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17b_Lizard_Beach.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17c_Troll_Hole.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17d_Cursed_Isle.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/19_The_Vanguard.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/20_Return_of_the_Fleet.cfg

  Log Message:
  -----------
  TRoW: [scenario] does not support bonus=yes


  Commit: 1c9e1993fef3f567463bdea48b50527c9d40003b
      https://github.com/wesnoth/wesnoth/commit/1c9e1993fef3f567463bdea48b50527c9d40003b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/16_The_Kalian.cfg
    A data/campaigns/The_Rise_Of_Wesnoth/units/Kalian.cfg

  Log Message:
  -----------
  TRoW: [unit]image= is not supported

Instead we must use a custom unit type to get the desired effect

With this, TRoW is now clean of schema errors


  Commit: 282dd7ef46f7dd43957d06a40264610f2b2fff90
      https://github.com/wesnoth/wesnoth/commit/282dd7ef46f7dd43957d06a40264610f2b2fff90
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg

  Log Message:
  -----------
  HTTT, SoF: Fix a couple more issues found by the schema validator

With this, HTTT and SoF are now clean of schema errors


  Commit: 0ec181686d66c11555c53221b52a16bd3951bef3
      https://github.com/wesnoth/wesnoth/commit/0ec181686d66c11555c53221b52a16bd3951bef3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Test scenario: remove useless [object]silent=yes


  Commit: 7267f1934e8221306775038b5a3fdc5164ff0f8a
      https://github.com/wesnoth/wesnoth/commit/7267f1934e8221306775038b5a3fdc5164ff0f8a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Test scenario: Fix invalid [message] key


  Commit: c74426e59254ddb6b81814fca95d574c8744c587
      https://github.com/wesnoth/wesnoth/commit/c74426e59254ddb6b81814fca95d574c8744c587
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/scenario-story.cfg

  Log Message:
  -----------
  Story test scenario: Fix misplaced duplicate map data


  Commit: 301746cb2b17f049ec4b2df4ae7244a722ac64df
      https://github.com/wesnoth/wesnoth/commit/301746cb2b17f049ec4b2df4ae7244a722ac64df
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg

  Log Message:
  -----------
  LoW: [scenario]snapshot= is not supported

With this, LoW is as clean of schema errors as it's going to get
The custom [replace_map] override prevents it getting any cleaner for 1.14


  Commit: ec2c2d74d27d8b9348aeccebb6ae2f63bcd4ef98
      https://github.com/wesnoth/wesnoth/commit/ec2c2d74d27d8b9348aeccebb6ae2f63bcd4ef98
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter3/12_Revelations.cfg

  Log Message:
  -----------
  LoW MP: Fix a few more issues found by the schema validator

With this, LoW MP is as clean of schema errors as it's going to get


  Commit: 05143cc65fed6c890fb0dc639bd995a0cca302b1
      https://github.com/wesnoth/wesnoth/commit/05143cc65fed6c890fb0dc639bd995a0cca302b1
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/ai/scenarios/ai_arena_small/0002-poisoning.cfg
    M data/ai/scenarios/scenario-poisoning.cfg
    M data/scenario-test.cfg

  Log Message:
  -----------
  Fix a few schema issues in some of the interactive test scenarios


  Commit: 77cebfb74e83ca07c9b56bb670dfcce07dc272d3
      https://github.com/wesnoth/wesnoth/commit/77cebfb74e83ca07c9b56bb670dfcce07dc272d3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/ai/micro_ais/scenarios/dragon.cfg
    M data/ai/micro_ais/scenarios/goto.cfg
    M data/ai/micro_ais/scenarios/guardians.cfg
    M data/ai/micro_ais/scenarios/hang_out.cfg
    M data/ai/micro_ais/scenarios/messenger_escort.cfg
    M data/ai/micro_ais/scenarios/patrols.cfg
    M data/ai/micro_ais/scenarios/protect_unit.cfg

  Log Message:
  -----------
  MicroAI Tests: Fix issues found by the schema validator

With this, the MicroAI test scenarios are clean of schema errors


  Commit: b26f02919d0920fd64a0ffc5f157d35201c9938e
      https://github.com/wesnoth/wesnoth/commit/b26f02919d0920fd64a0ffc5f157d35201c9938e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M data/test/maps/pathfind_1.cfg
    M data/test/scenarios/test_menu_items.cfg

  Log Message:
  -----------
  WML Unit Tests: Fix issues found by the schema validator

With this, the WML unit tests are as clean of schema errors as they can get
The two remaining errors are unit tests for dealing with invalid input,
so they are intentionally violating the schema.


Compare: https://github.com/wesnoth/wesnoth/compare/65e0f232b29d...b26f02919d09


More information about the Commits mailing list