[wesnoth-commits] [wesnoth/wesnoth] c446e6: IPFs: simplify ~TC() implementation

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c446e679f0cb205d47c7a55ceb9f57817321070c
      https://github.com/wesnoth/wesnoth/commit/c446e679f0cb205d47c7a55ceb9f57817321070c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-10 (Tue, 10 Apr 2018)

  Changed paths:
    M src/image_modifications.cpp

  Log Message:
  -----------
  IPFs: simplify ~TC() implementation

This results in the same behavior as before (default color outside a scenario, side's
chosen color during one) and is more consistent with other places in the code. They
both end up accessing `game_config::team_rgb_range` anyway, this is just in a slightly
more roundabout way.


  Commit: 15fdabbac9a79de06de87128cdaa93c3edda8e11
      https://github.com/wesnoth/wesnoth/commit/15fdabbac9a79de06de87128cdaa93c3edda8e11
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-10 (Tue, 10 Apr 2018)

  Changed paths:
    M src/display.cpp
    M src/image.cpp
    M src/image.hpp
    M src/tests/test_image_modifications.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Removed now-unused storage of team colors in the image namespace

Was used by ~TC(). That now uses the team class color helpers.


Compare: https://github.com/wesnoth/wesnoth/compare/325691107ab5...15fdabbac9a7