[wesnoth-commits] [wesnoth/wesnoth] d0e415: Fix erroneous/useless [event] in [titlescreen_musi...

GitHub noreply at github.com
Thu Apr 12 01:12:23 UTC 2018


  Branch: refs/heads/schema_fixes
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d0e41518b1669cf7e6e596de281b3f41e9e0eb9d
      https://github.com/wesnoth/wesnoth/commit/d0e41518b1669cf7e6e596de281b3f41e9e0eb9d
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/core/editor/_main.cfg
    M data/core/editor/music.cfg
    M data/core/macros/sound-utils.cfg
    M data/multiplayer/_main.cfg

  Log Message:
  -----------
  Fix erroneous/useless [event] in [titlescreen_music], [lobby_music], [editor_music]

The playlist macros set the music list twice, once before the
story screen and again in prestart, but the order of tracks is different.

This means that the track order at the titlescreen and in the lobby is now the same
as the track order in a scenario using the default playlist, which previously was not the case.

Similarly, the track order in the editor is now the same as the track order
in a scenario using the full playlist.

Whether that actually matters? I have no idea. I doubt it.

In any case, as of this commit, there are no schema validation errors
at the title screen, when entering the MP Create screen, or in the map editor.


  Commit: afddd612fc54d6941f800d5130151e52fd670783
      https://github.com/wesnoth/wesnoth/commit/afddd612fc54d6941f800d5130151e52fd670783
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/ai/micro_ais/scenarios/The_Elves_Besieged.cfg
    M data/ai/micro_ais/scenarios/animals.cfg
    M data/ai/micro_ais/scenarios/bottleneck_defense.cfg
    M data/ai/micro_ais/scenarios/dragon.cfg
    M data/ai/micro_ais/scenarios/fast.cfg
    M data/ai/micro_ais/scenarios/goto.cfg
    M data/ai/micro_ais/scenarios/guardians.cfg
    M data/ai/micro_ais/scenarios/hang_out.cfg
    M data/ai/micro_ais/scenarios/healer_support.cfg
    M data/ai/micro_ais/scenarios/lurkers.cfg
    M data/ai/micro_ais/scenarios/messenger_escort.cfg
    M data/ai/micro_ais/scenarios/patrols.cfg
    M data/ai/micro_ais/scenarios/protect_unit.cfg
    M data/ai/micro_ais/scenarios/recruiting.cfg
    M data/ai/micro_ais/scenarios/scenario_micro_ai.cfg
    M data/ai/micro_ais/scenarios/simple_attack.cfg
    M data/ai/micro_ais/scenarios/swarm.cfg
    M data/ai/micro_ais/scenarios/wolves.cfg
    M data/ai/scenarios/scenario-AI_Arena_small.cfg
    M data/ai/scenarios/scenario-high_xp_attack.cfg
    M data/campaigns/Dead_Water/scenarios/08_Talking_to_Tyegea.cfg
    M data/campaigns/Dead_Water/scenarios/11_Getting_Help.cfg
    M data/campaigns/Dead_Water/scenarios/12_Revenge.cfg
    M data/campaigns/Dead_Water/scenarios/13_Epilogue.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/16_Dark_Sky_Over_Weldyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/23_Epilogue.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/12_Endless_Night.cfg
    M data/campaigns/Eastern_Invasion/scenarios/08_Training_the_Ogres.cfg
    M data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg
    M data/campaigns/Eastern_Invasion/scenarios/17a_The_Duel.cfg
    M data/campaigns/Eastern_Invasion/scenarios/17b_Weldyn_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/14_Plunging_Into_the_Darkness.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg
    M data/campaigns/Northern_Rebirth/scenarios/14a_Epilogue.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/9_Caverns_of_Flame.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/09_Training_Session.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/21_Against_the_World.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/22_Epilogue.cfg
    M data/campaigns/Son_Of_The_Black_Eye/scenarios/18_Northern_Alliance.cfg
    M data/campaigns/Son_Of_The_Black_Eye/scenarios/19_Epilogue.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/02_Reclaiming_the_Past.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/13_Epilogue.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/15_A_New_Land.cfg
    M data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg
    M data/campaigns/The_South_Guard/scenarios/09a_Vengeance.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07b_Talking_with_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/13_Epilogue.cfg
    M data/multiplayer/scenarios/2p_Dark_Forecast.cfg
    M data/scenario-leaders.cfg
    M data/scenario-movethrough.cfg
    M data/scenario-test.cfg

  Log Message:
  -----------
  Embrace turns=unlimited as a way of specifying unlimited turns


  Commit: 649e927ebf695c105e0843b808b32b7aefa24468
      https://github.com/wesnoth/wesnoth/commit/649e927ebf695c105e0843b808b32b7aefa24468
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/multiplayer/scenarios/ANL_utils/ANL_general_macros.cfg
    M data/multiplayer/scenarios/ANL_utils/ANL_special_macros.cfg

  Log Message:
  -----------
  ANL: Remove needless silent= key from [object]s

The silent key is meaningful only when using the [object] as ActionWML.
None of these are used thusly, so it does nothing.


  Commit: d988d966bd64c5d7efdc161ccee24de1b42dabf0
      https://github.com/wesnoth/wesnoth/commit/d988d966bd64c5d7efdc161ccee24de1b42dabf0
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/01_The_Uprooting.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/02_Hostile_Mountains.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/03_Kalian_under_Attack.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/04_The_Elvish_Treasury.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/05_The_Saurian_Treasury.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/06_Acquaintance_in_Need.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter5/22_Northern_Battle.cfg

  Log Message:
  -----------
  LoW: Remove redundant AI definitions

These are used by default, so there's no need to specifically include them.


  Commit: 395ac5cd13622da07e007579091e8d0f74ff4fc1
      https://github.com/wesnoth/wesnoth/commit/395ac5cd13622da07e007579091e8d0f74ff4fc1
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg

  Log Message:
  -----------
  LoW7: Fix invalid use of aspects in [unit][ai]

This doesn't quite produce what is presumed to be the intended result.
It does at least preserve the differing recruitment patterns though.

Includes the following recommendations from mattsc:

- Drop {AI_NO_SCOUTS} since the recruitment pattern contradicts it
- Drop attack_depth and grouping
- Keep the night-only aggression and caution change, even for the nagas


  Commit: c506788894b6ee1f7163c8ccbb9421c00bab079a
      https://github.com/wesnoth/wesnoth/commit/c506788894b6ee1f7163c8ccbb9421c00bab079a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/utils/characters.cfg

  Log Message:
  -----------
  LoW: Fix erroneous used of unrenamable and canrecruit keys in [side] when there is no unit


  Commit: e6f88c8f93a81e66de88011aec9899b66c078966
      https://github.com/wesnoth/wesnoth/commit/e6f88c8f93a81e66de88011aec9899b66c078966
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/core/macros/ai_controller.cfg

  Log Message:
  -----------
  Fix error in AI control core macros


  Commit: 5e6b4c41506bfe54b10e2a703e62b06d85ef0db4
      https://github.com/wesnoth/wesnoth/commit/5e6b4c41506bfe54b10e2a703e62b06d85ef0db4
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter2/08_Council_of_Hard_Choices.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter3/09_Bounty_Hunters.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/16_The_Chief_Must_Die.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/17_Breaking_the_Siege.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter5/21_Elvish_Assassins.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter5/23_End_of_War.cfg
    M data/campaigns/Legend_of_Wesmere/utils/characters.cfg

  Log Message:
  -----------
  LoW: Several small fixes (misplaced keys mostly)


  Commit: e248a5da9c91975d815d95d6e6dcc9e1484e4da2
      https://github.com/wesnoth/wesnoth/commit/e248a5da9c91975d815d95d6e6dcc9e1484e4da2
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Two_Brothers/scenarios/01_Rooting_Out_a_Mage.cfg
    M data/campaigns/Two_Brothers/scenarios/02_The_Chase.cfg

  Log Message:
  -----------
  TB: Fix errors found by schema validator

- Passing () as the side to the unit util macros results in an empty side key
  There's no reason not to just pass 1 instead though.
- [modify_side] does not support [filter]; instead it uses [filter_side]
  However, it also supports inline side which is sufficient here,
  so just use that instead.

This covers both difficulty levels; TB is now clean of schema issues.


  Commit: 0891b102c9f3c6743bfb12d19a9fdfbb414b05fb
      https://github.com/wesnoth/wesnoth/commit/0891b102c9f3c6743bfb12d19a9fdfbb414b05fb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/An_Orcish_Incursion/scenarios/02_Assassins.cfg
    M data/campaigns/An_Orcish_Incursion/scenarios/04_Valley_of_Trolls.cfg

  Log Message:
  -----------
  AOI: Fix errors found by schema validator

- grouping=no, not grouping=none
- speaker is a message key not a filter key

With this, AOI is clean of schema issues.


  Commit: 3fd4f96624adc17c48564828cf58ba3f04e9b2eb
      https://github.com/wesnoth/wesnoth/commit/3fd4f96624adc17c48564828cf58ba3f04e9b2eb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/core/macros/unit-utils.cfg

  Log Message:
  -----------
  Remove animate=no from {GUARDIAN}

This is the default in [unit] anyway, and if the user specified
animate=yes explicitly then we should not override that.


  Commit: 236fd6f5c4878f8a4af005c276a7bed615b1bead
      https://github.com/wesnoth/wesnoth/commit/236fd6f5c4878f8a4af005c276a7bed615b1bead
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg
    M data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg
    M data/campaigns/The_South_Guard/scenarios/06b_The_Long_March.cfg

  Log Message:
  -----------
  TSG: Fix errors found by schema validator

With this, TSG is now clean of schema issues


  Commit: 2001424cada260bf6a22cad5d81a173007861ddb
      https://github.com/wesnoth/wesnoth/commit/2001424cada260bf6a22cad5d81a173007861ddb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/units/Battle_Princess.cfg
    M data/campaigns/Heir_To_The_Throne/units/Commander.cfg
    M data/campaigns/Heir_To_The_Throne/units/Fighter.cfg
    M data/campaigns/Heir_To_The_Throne/units/Lord.cfg
    M data/campaigns/Heir_To_The_Throne/units/Princess.cfg

  Log Message:
  -----------
  HTTT: Unit variations don't need an ID


  Commit: 50df7717e5520c7f09049db7584d88f91439d12c
      https://github.com/wesnoth/wesnoth/commit/50df7717e5520c7f09049db7584d88f91439d12c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/core/macros/items.cfg

  Log Message:
  -----------
  [effect]apply_to=new_animation does not support name

It does support id though, which is used as a sort of caching mechanism
in case the same effect is applied many times, so use that instead of name.
For good measure, also use an id on the sceptre of fire animation


  Commit: 3df296e0991e58ae530fdd757d03353be1ee3a3e
      https://github.com/wesnoth/wesnoth/commit/3df296e0991e58ae530fdd757d03353be1ee3a3e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/09_The_Valley_of_Death.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg

  Log Message:
  -----------
  HTTT: Fix errors found by schema validator

This fixes most of the errors, but there still a few more to squelch.


  Commit: f77a849392297f90e1a51f7868b5d9ba98f94c35
      https://github.com/wesnoth/wesnoth/commit/f77a849392297f90e1a51f7868b5d9ba98f94c35
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Eastern_Invasion/scenarios/07a_The_Crossing.cfg
    M data/campaigns/Eastern_Invasion/scenarios/07b_Undead_Crossing.cfg
    M data/campaigns/Eastern_Invasion/scenarios/09_Xenophobia.cfg
    M data/campaigns/Eastern_Invasion/scenarios/11_Captured.cfg
    M data/campaigns/Eastern_Invasion/scenarios/17a_The_Duel.cfg

  Log Message:
  -----------
  EI: Fix issues found by the schema validator

With this, EI is as clean of schema errors as it's going to get.
There yet remain a number of unsolvable schema errors (due to multi-use macros).

Regarding {LOYAL_UNIT}, specifying the side here is redundant;
however, an empty side key raises an error, and it doesn't hurt
to specify the redundant information.


  Commit: b4f839a721b844d3875139db8c81695b29e879eb
      https://github.com/wesnoth/wesnoth/commit/b4f839a721b844d3875139db8c81695b29e879eb
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg

  Log Message:
  -----------
  HoT: Fix issues found by the schema validator

With this, HoT is clean of schema errors


  Commit: df462e54c6ad988a6204c14ff1881da285087901
      https://github.com/wesnoth/wesnoth/commit/df462e54c6ad988a6204c14ff1881da285087901
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Descent_Into_Darkness/scenarios/01_Saving_Parthyn.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/03_A_Haunting_in_Winter.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/09_A_Small_Favor3.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/10_Alone_at_Last.cfg
    M data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg

  Log Message:
  -----------
  DiD: Fix issues found by the schema validator

With this, DiD is now clean of schema errors


  Commit: 97552993624010dc735767a3e9379deb940d3e80
      https://github.com/wesnoth/wesnoth/commit/97552993624010dc735767a3e9379deb940d3e80
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg

  Log Message:
  -----------
  DM: Fix issues found by the schema validator

With this, DM is now clean of schema errors


  Commit: b8f96d0352abfde0fb1007bbc8e4e0a460938e15
      https://github.com/wesnoth/wesnoth/commit/b8f96d0352abfde0fb1007bbc8e4e0a460938e15
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Dead_Water/scenarios/01_Invasion.cfg
    M data/campaigns/Dead_Water/scenarios/04_Slavers.cfg

  Log Message:
  -----------
  DW: Remove [message]duration key since it does absolutely nothing


  Commit: 6912e1255032a8512a3b53173e15fe6b00b730a2
      https://github.com/wesnoth/wesnoth/commit/6912e1255032a8512a3b53173e15fe6b00b730a2
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg

  Log Message:
  -----------
  DW: Fix a couple more issues found by the schema validator

With this, DW is clean of schema errors


  Commit: 667ae9ec1fc11e72401d466835c73aff5806ae45
      https://github.com/wesnoth/wesnoth/commit/667ae9ec1fc11e72401d466835c73aff5806ae45
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/maps/02_Dark_Business.map
    M data/campaigns/Secrets_of_the_Ancients/maps/03_Bandits.map
    M data/campaigns/Secrets_of_the_Ancients/maps/04_Becalmed.map
    M data/campaigns/Secrets_of_the_Ancients/maps/06_Following_the_Shadow.map
    M data/campaigns/Secrets_of_the_Ancients/maps/07_Meeting_of_the_Minds.map
    M data/campaigns/Secrets_of_the_Ancients/maps/08_Carcyn.map
    M data/campaigns/Secrets_of_the_Ancients/maps/09_Training_Session.map
    M data/campaigns/Secrets_of_the_Ancients/maps/11_Battleground.map
    M data/campaigns/Secrets_of_the_Ancients/maps/12_Walking_Trees.map
    M data/campaigns/Secrets_of_the_Ancients/maps/13_Together_Again.map
    M data/campaigns/Secrets_of_the_Ancients/maps/14_Entering_the_Northlands.map
    M data/campaigns/Secrets_of_the_Ancients/maps/15_Mountain_Pass.map
    M data/campaigns/Secrets_of_the_Ancients/maps/16_The_Mage.map
    M data/campaigns/Secrets_of_the_Ancients/maps/17_Mortality.map
    M data/campaigns/Secrets_of_the_Ancients/maps/18_Abandoned_Outpost.map
    M data/campaigns/Secrets_of_the_Ancients/maps/19_Lava_and_Stone.map

  Log Message:
  -----------
  SotA: Remove obsolete map headers


  Commit: 6217cde5aada11f798e0f8cdbef75da01e697622
      https://github.com/wesnoth/wesnoth/commit/6217cde5aada11f798e0f8cdbef75da01e697622
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/02_Dark_Business.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/05_Blackwater.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/20_North_Knalga.cfg
    M data/campaigns/Secrets_of_the_Ancients/utils/sota-utils.cfg

  Log Message:
  -----------
  SotA: Remove weird terrain='' convention

The wiki proscribes terrain=^ for this purpose, which has the bonus
of being detected as a valid terrain code by the schema.


  Commit: fcd3d8fb72f65306d4c6fb7d7ad785bcc0c9a82b
      https://github.com/wesnoth/wesnoth/commit/fcd3d8fb72f65306d4c6fb7d7ad785bcc0c9a82b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/06_Following_the_Shadow.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/07_Meeting_of_the_Minds.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/15_Mountain_Pass.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/21_Against_the_World.cfg

  Log Message:
  -----------
  SotA: Fix a few more issues found by the schema validator

With this, SotA is now clean of schema errors


  Commit: c62e717d0e5c4ab8b42c20ad20db52d4970ea2f5
      https://github.com/wesnoth/wesnoth/commit/c62e717d0e5c4ab8b42c20ad20db52d4970ea2f5
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Sceptre_of_Fire/scenarios/1_A_Bargain_is_Struck.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/9_Caverns_of_Flame.cfg

  Log Message:
  -----------
  SoF: Fix issues found by the schema validator


  Commit: 39ac4217b3670a34a8674cc276ae65de6eb4c638
      https://github.com/wesnoth/wesnoth/commit/39ac4217b3670a34a8674cc276ae65de6eb4c638
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg

  Log Message:
  -----------
  NR: usage= and alignment= not supported in SUF


  Commit: acf5a20b5bd4cb211a5fbc82ec613ea9cd4f4ce7
      https://github.com/wesnoth/wesnoth/commit/acf5a20b5bd4cb211a5fbc82ec613ea9cd4f4ce7
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/02_01_Infested_Caves.cfg
    M data/campaigns/Northern_Rebirth/scenarios/02_02_Meeting_With_Dwarves.cfg
    M data/campaigns/Northern_Rebirth/scenarios/04_Clearing_the_Mines.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_02_Dealings.cfg
    M data/campaigns/Northern_Rebirth/scenarios/07a_Settling_Disputes.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09a_Introductions.cfg
    M data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg

  Log Message:
  -----------
  NR: Explicitly specify redundant side parameter in unit macros


  Commit: 95c736a55dd19a06940a9668516251f739a9e5f5
      https://github.com/wesnoth/wesnoth/commit/95c736a55dd19a06940a9668516251f739a9e5f5
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg

  Log Message:
  -----------
  NR: [ai]villages_per_scout= is an integer


  Commit: 98552d8cf17e300d42d8cff22189506c09fbdef6
      https://github.com/wesnoth/wesnoth/commit/98552d8cf17e300d42d8cff22189506c09fbdef6
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/12a_Get_the_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg

  Log Message:
  -----------
  NR: [store_unit] does not support fire_event


  Commit: 1d0a2fd1cebcd4f61e65140b4124417bcc12e4bd
      https://github.com/wesnoth/wesnoth/commit/1d0a2fd1cebcd4f61e65140b4124417bcc12e4bd
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/01_Breaking_the_Chains.cfg
    M data/campaigns/Northern_Rebirth/scenarios/06a_Old_Friend.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg
    M data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg

  Log Message:
  -----------
  NR: Fix a few more issues found by the schema validator

With this, NR is clean of schema issues


  Commit: cecec264ce25b78c99d990d59825dd4471785197
      https://github.com/wesnoth/wesnoth/commit/cecec264ce25b78c99d990d59825dd4471785197
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/01_The_Morning_After.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/02_Across_the_Harsh_Sands.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg

  Log Message:
  -----------
  UtBS: [objectives] does not support show=


  Commit: 1e879c3dc950b060c250448296ccd15e7bbde419
      https://github.com/wesnoth/wesnoth/commit/1e879c3dc950b060c250448296ccd15e7bbde419
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/04_Descending_into_Darkness.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07b_Talking_with_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/11_Battle_for_Zocthanol_Isle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/13_Epilogue.cfg

  Log Message:
  -----------
  UtBS: [scenario]snapshot= doesn't seem like it would have any useful effect

(It's probably technically valid, as this key is part of the savegame WML.)


  Commit: b9ac4a12cadbbbb86906ea1c575e088deac2d233
      https://github.com/wesnoth/wesnoth/commit/b9ac4a12cadbbbb86906ea1c575e088deac2d233
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/06a_In_the_Tunnels_of_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg

  Log Message:
  -----------
  UtBS: silent= is meaningless in [object][modifications]


  Commit: 0d6efe61557faa464acc1f0cb18306f2e9dab296
      https://github.com/wesnoth/wesnoth/commit/0d6efe61557faa464acc1f0cb18306f2e9dab296
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg

  Log Message:
  -----------
  UtBS: Fix a few more issues found by the schema validator

With this, UtBS is as clean of schema errors as it'll get
(There are still two spurious errors remaining)


  Commit: d3106398c15bef75c592d99abc794b30acdf20b0
      https://github.com/wesnoth/wesnoth/commit/d3106398c15bef75c592d99abc794b30acdf20b0
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/21_The_Plan.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/23_Epilogue.cfg

  Log Message:
  -----------
  TRoW: Fix a couple of issues found by the schema validator


  Commit: d7185f76914c84793715452a15305bb65c2e5f2a
      https://github.com/wesnoth/wesnoth/commit/d7185f76914c84793715452a15305bb65c2e5f2a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/utils/intro.cfg

  Log Message:
  -----------
  HTTT: Fix toplevel [story]


  Commit: 0c48c66ba5fdf8db553184e28fafcd88ad40de9a
      https://github.com/wesnoth/wesnoth/commit/0c48c66ba5fdf8db553184e28fafcd88ad40de9a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04a_The_Swamp_of_Esten.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04b_The_Midlands.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/11_Southbay_in_Winter.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/12_A_Final_Spring.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/13_Peoples_in_Decline.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/14_Rough_Landing.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/15_A_New_Land.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17a_The_Dragon.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17b_Lizard_Beach.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17c_Troll_Hole.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17d_Cursed_Isle.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/19_The_Vanguard.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/20_Return_of_the_Fleet.cfg

  Log Message:
  -----------
  TRoW: [scenario] does not support bonus=yes


  Commit: 752e016cc7d5622b36d80ae663441371c95bdd8a
      https://github.com/wesnoth/wesnoth/commit/752e016cc7d5622b36d80ae663441371c95bdd8a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/16_The_Kalian.cfg
    A data/campaigns/The_Rise_Of_Wesnoth/units/Kalian.cfg

  Log Message:
  -----------
  TRoW: [unit]image= is not supported

Instead we must use a custom unit type to get the desired effect

With this, TRoW is now clean of schema errors


  Commit: 9e88bee292e027cf0d453dd6fefd39356b42afda
      https://github.com/wesnoth/wesnoth/commit/9e88bee292e027cf0d453dd6fefd39356b42afda
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/16_The_Kalian.cfg
    R data/campaigns/The_Rise_Of_Wesnoth/units/Kalian.cfg

  Log Message:
  -----------
  TRoW: [unit]image= is not supported

We should really use a custom unit type to get the desired effect;
however, that could cause out-of-sync errors, so for the 1.14 branch
we instead replace the image via an [object]

With this, TRoW is now clean of schema errors


  Commit: dd12cbcf52c6cdc7f64bf72ff5c4afb06cd99e1a
      https://github.com/wesnoth/wesnoth/commit/dd12cbcf52c6cdc7f64bf72ff5c4afb06cd99e1a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg

  Log Message:
  -----------
  HTTT, SoF: Fix a couple more issues found by the schema validator

With this, HTTT and SoF are now clean of schema errors


  Commit: 1a0cebf9ecb0597b5578de76b834685498a9728e
      https://github.com/wesnoth/wesnoth/commit/1a0cebf9ecb0597b5578de76b834685498a9728e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Test scenario: remove useless [object]silent=yes


  Commit: f8f4dedc4b38a51052d4fbcdd26006d96975a87b
      https://github.com/wesnoth/wesnoth/commit/f8f4dedc4b38a51052d4fbcdd26006d96975a87b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/scenario-test.cfg

  Log Message:
  -----------
  Test scenario: Fix invalid [message] key


  Commit: a5347639287d2eadbca365d59a8e7ccb2cbe4459
      https://github.com/wesnoth/wesnoth/commit/a5347639287d2eadbca365d59a8e7ccb2cbe4459
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/scenario-story.cfg

  Log Message:
  -----------
  Story test scenario: Fix misplaced duplicate map data


  Commit: fa591e04ea61066ef20f8980a7234baa08528e7f
      https://github.com/wesnoth/wesnoth/commit/fa591e04ea61066ef20f8980a7234baa08528e7f
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg

  Log Message:
  -----------
  LoW: [scenario]snapshot= is not supported

With this, LoW is as clean of schema errors as it's going to get
The custom [replace_map] override prevents it getting any cleaner for 1.14


  Commit: 282178e42ef590d8e6c698faa6b93d9ffed4ec67
      https://github.com/wesnoth/wesnoth/commit/282178e42ef590d8e6c698faa6b93d9ffed4ec67
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter3/12_Revelations.cfg

  Log Message:
  -----------
  LoW MP: Fix a few more issues found by the schema validator

With this, LoW MP is as clean of schema errors as it's going to get


  Commit: fc5e3c59cca39f77d3d68581a587c3eb2551e328
      https://github.com/wesnoth/wesnoth/commit/fc5e3c59cca39f77d3d68581a587c3eb2551e328
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/ai/scenarios/ai_arena_small/0002-poisoning.cfg
    M data/ai/scenarios/scenario-poisoning.cfg
    M data/scenario-test.cfg

  Log Message:
  -----------
  Fix a few schema issues in some of the interactive test scenarios


  Commit: d16813a33e688a6a88be0e9a9b4b5a344ee8f5cf
      https://github.com/wesnoth/wesnoth/commit/d16813a33e688a6a88be0e9a9b4b5a344ee8f5cf
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/ai/micro_ais/scenarios/dragon.cfg
    M data/ai/micro_ais/scenarios/goto.cfg
    M data/ai/micro_ais/scenarios/guardians.cfg
    M data/ai/micro_ais/scenarios/hang_out.cfg
    M data/ai/micro_ais/scenarios/messenger_escort.cfg
    M data/ai/micro_ais/scenarios/patrols.cfg
    M data/ai/micro_ais/scenarios/protect_unit.cfg

  Log Message:
  -----------
  MicroAI Tests: Fix issues found by the schema validator

With this, the MicroAI test scenarios are clean of schema errors


  Commit: ff627782fce2b820cc4fbd9a6377b2eb0317a8b2
      https://github.com/wesnoth/wesnoth/commit/ff627782fce2b820cc4fbd9a6377b2eb0317a8b2
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-11 (Wed, 11 Apr 2018)

  Changed paths:
    M data/test/maps/pathfind_1.cfg
    M data/test/scenarios/test_menu_items.cfg

  Log Message:
  -----------
  WML Unit Tests: Fix issues found by the schema validator

With this, the WML unit tests are as clean of schema errors as they can get
The two remaining errors are unit tests for dealing with invalid input,
so they are intentionally violating the schema.


Compare: https://github.com/wesnoth/wesnoth/compare/8ae121299ff9...ff627782fce2


More information about the Commits mailing list