[wesnoth-commits] [wesnoth/wesnoth] 1597a2: AI recruitment: fix units on recall list interferi...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1597a2ce273e2f6f89221fc9fa10590892f43043
      https://github.com/wesnoth/wesnoth/commit/1597a2ce273e2f6f89221fc9fa10590892f43043
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/ai/default/recruitment.cpp
    M src/ai/default/recruitment.hpp

  Log Message:
  -----------
  AI recruitment: fix units on recall list interfering with recruiting

Units on the recall list are treated as recruits by the AI. The code
previously did not check whether a unit it worth being recalled until
after it makes the decision which unit type to recruit/recall. If it
then can only recall, but not recruit units of that type and all of
them are deemed not worth it, the entire recruitment CA is disabled
(via black listing), meaning recruiting is abandoned also.

This commit fixes this by checking the unit value vs. the recall cost
before putting recalls on the recruitment list.


  Commit: 0119413910591aa9e8ced71c9702271df51b67c4
      https://github.com/wesnoth/wesnoth/commit/0119413910591aa9e8ced71c9702271df51b67c4
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-04-12 (Thu, 12 Apr 2018)

  Changed paths:
    M src/ai/default/recruitment.cpp

  Log Message:
  -----------
  AI recruitment: use unit-specific recall cost

… when deciding whether a recall is worth it.


  Commit: 84c39de58d0e4cad7e0f474dca833ef60e8c3f65
      https://github.com/wesnoth/wesnoth/commit/84c39de58d0e4cad7e0f474dca833ef60e8c3f65
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-04-13 (Fri, 13 Apr 2018)

  Changed paths:
    M src/ai/default/recruitment.cpp
    M src/ai/default/recruitment.hpp

  Log Message:
  -----------
  Merge pull request #2876 from mattsc/recall_recruit_bug

AI recruitment: fix units on recall list interfering with recruiting


Compare: https://github.com/wesnoth/wesnoth/compare/e09afcffb5ad...84c39de58d0e