[wesnoth-commits] [wesnoth/wesnoth] e583c4: Display: cleaned up overlay map getter interface

GitHub noreply at github.com
Thu Apr 19 23:49:11 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e583c470be597b486e447d0a0abfea820b1afc43
      https://github.com/wesnoth/wesnoth/commit/e583c470be597b486e447d0a0abfea820b1afc43
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-20 (Fri, 20 Apr 2018)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/editor/editor_display.cpp
    M src/editor/editor_display.hpp
    M src/editor/map/context_manager.cpp
    M src/game_display.cpp
    M src/game_display.hpp

  Log Message:
  -----------
  Display: cleaned up overlay map getter interface

Instead of a pointer to a member of a derived class, used a virtual function implemented
in both derived classes (game_display and editor_display) that return an reference to the
appropriate object.

Also removed the overlay.hpp include from display.hpp. We can forward-declare the overlay
struct.




More information about the Commits mailing list