[wesnoth-commits] [wesnoth/wesnoth] 2a8ac2: fix 'start game' locked when other players abort f...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2a8ac2e6afeae0f050ea28e36eaf0c370ba1970e
      https://github.com/wesnoth/wesnoth/commit/2a8ac2e6afeae0f050ea28e36eaf0c370ba1970e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-08-11 (Sat, 11 Aug 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.hpp

  Log Message:
  -----------
  fix 'start game' locked when other players abort flg dialog #3452


  Commit: 2f21f1aec340ea081001e7745f9b16e6ff643a3e
      https://github.com/wesnoth/wesnoth/commit/2f21f1aec340ea081001e7745f9b16e6ff643a3e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp

  Log Message:
  -----------
  boost::ptr_vector -> std::vector<unique_ptr>

boost::ptr_vector has some nice features, but vector<unique_ptr> is still
easier to use for most people basicially becasue people know it better.
Also boost::ptr_vector does not support move ctors and also does not
use std::unique_ptr, probably because it tries to stay compatible with
c++03 so one has to use 'ptr_vector::auto_type' with it instead which
has a different interface than std::unique_ptr


  Commit: f0ffb458f2ee516b5c73bb44935df459aa02dfe7
      https://github.com/wesnoth/wesnoth/commit/f0ffb458f2ee516b5c73bb44935df459aa02dfe7
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp

  Log Message:
  -----------
  fix game freezes on droiding when using dsu #3453


  Commit: 717a43c49004aa0185c2f2fde7282af992e61356
      https://github.com/wesnoth/wesnoth/commit/717a43c49004aa0185c2f2fde7282af992e61356
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M src/server/simple_wml.cpp
    M src/server/simple_wml.hpp

  Log Message:
  -----------
  Revert "preserve traslatable strings in simple_wml."

This reverts commit 4f3ce6865cdd628634fc3ffe2154093d6ccbfba4.
This reverts commit 20128ac9914c971d759399dff6f7ed8edcb960c8.

see issue #3454, there were problems caused by simple_wml when
joining/observing games and this commit is the obvious suspect
so i'm reverting it until we can fix that one.


Compare: https://github.com/wesnoth/wesnoth/compare/c10fc7f08a82...717a43c49004
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.