[wesnoth-commits] [wesnoth/wesnoth] d9b114: RCA AI manager: remove unused function add_ai_for_...

GitHub noreply at github.com
Sun Dec 2 16:42:43 UTC 2018 

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d9b1146a70fdf003ee8a29e4b67a096da2b97c71
      https://github.com/wesnoth/wesnoth/commit/d9b1146a70fdf003ee8a29e4b67a096da2b97c71
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-15 (Thu, 15 Nov 2018)

  Changed paths:
    M src/ai/manager.cpp
    M src/ai/manager.hpp

  Log Message:
  -----------
  RCA AI manager: remove unused function add_ai_for_side()

This is done by add_ai_for_side_from_file() and add_ai_for_side_from_config() now.


  Commit: f8871d9ad8b4e63a2fb12fa5bc86e22217558b42
      https://github.com/wesnoth/wesnoth/commit/f8871d9ad8b4e63a2fb12fa5bc86e22217558b42
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M src/ai/contexts.cpp
    M src/ai/contexts.hpp
    M src/recall_list_manager.hpp

  Log Message:
  -----------
  RCA AI: remove unused function get_recall_list()

This also let's us get rid of the friend declaration in recall_list_mamnager.hpp as indicated in the TODO comment.


  Commit: 0ff1d9000234447ba90e3a0a33b8a0b8a64d30e4
      https://github.com/wesnoth/wesnoth/commit/0ff1d9000234447ba90e3a0a33b8a0b8a64d30e4
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M src/ai/contexts.cpp
    M src/ai/contexts.hpp
    M src/ai/default/aspect_attacks.cpp
    M src/ai/formula/ai.cpp
    M src/ai/lua/core.cpp
    M src/ai/manager.cpp
    M src/ai/registry.cpp

  Log Message:
  -----------
  RCA AI: remove attack_depth aspect

It's been unused for many versions at this time.


  Commit: 3da48bb57a61e71dd4d61aff27e1b7e32f63be35
      https://github.com/wesnoth/wesnoth/commit/3da48bb57a61e71dd4d61aff27e1b7e32f63be35
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M src/ai/default/aspect_attacks.cpp

  Log Message:
  -----------
  RCA AI attack aspects: rename a variable

Done to indicate that this is not a configurable value any more (and has not been in a long time).


  Commit: 7c34313a41e8af752470d38118ea6e2fc6ba59a6
      https://github.com/wesnoth/wesnoth/commit/7c34313a41e8af752470d38118ea6e2fc6ba59a6
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M data/campaigns/An_Orcish_Incursion/scenarios/04_Valley_of_Trolls.cfg
    M data/campaigns/An_Orcish_Incursion/scenarios/05_Linaera_the_Quick.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/02_Blackwater_Port.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/03_The_Isle_of_Alduin.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/04_The_Bay_of_Pearls.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/05a_Muff_Malal_Peninsula.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/07_Crossroads.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/08_The_Princess_of_Wesnoth.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/09_The_Valley_of_Death.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/10_Gryphon_Mountain.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/11_The_Ford_of_Abez.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/12_Northern_Winter.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/13_The_Dwarven_Doors.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/14_Plunging_Into_the_Darkness.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/15_The_Lost_General.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/16_Hasty_Alliance.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/18_A_Choice_Must_Be_Made.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19a_Snow_Plains.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19b_Swamp_Of_Dread.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/20a_North_Elves.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/23_Test_of_the_Clans.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/24_Battle_for_Wesnoth.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/01_The_Uprooting.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/14_Human_Alliance.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/17_Breaking_the_Siege.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/01_At_the_East_Gate.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/03_Strange_Allies.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/04_Troll_Bridge.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/05_Invaders.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/06_High_Pass.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/07_Mages_and_Drakes.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/10_The_Siege_of_Kal_Kartha.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/11_The_Court_of_Karrag.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/01_A_Summer_of_Storms.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/02_The_Fall.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/03_A_Harrowing_Escape.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04a_The_Swamp_of_Esten.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04b_The_Midlands.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/06_Temple_in_the_Deep.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/08_Clearwater_Port.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/09_Fallen_Lich_Point.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/10_Sewer_of_Southbay.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/12_A_Final_Spring.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/13_Peoples_in_Decline.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/14_Rough_Landing.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17a_The_Dragon.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17b_Lizard_Beach.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17c_Troll_Hole.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17d_Cursed_Isle.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/19_The_Vanguard.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/20_Return_of_the_Fleet.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/22_The_Rise_of_Wesnoth.cfg
    M data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg
    M data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg
    M data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg
    M data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg
    M data/campaigns/The_South_Guard/scenarios/06b_The_Long_March.cfg
    M data/campaigns/The_South_Guard/scenarios/08a_Return_to_Kerlath.cfg
    M data/multiplayer/scenarios/2p_Dark_Forecast.cfg

  Log Message:
  -----------
  AI: remove attack_depth settings from mainline campaigns

The attack_depth aspect has not done anything in a long time.


  Commit: f53e3b9565d65a24d54b8abc00fe2b1c1c3310ad
      https://github.com/wesnoth/wesnoth/commit/f53e3b9565d65a24d54b8abc00fe2b1c1c3310ad
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M data/schema/ai/aspect_complex.cfg
    M data/schema/ai/aspect_simple.cfg
    M data/schema/ai/modify.cfg

  Log Message:
  -----------
  Schema validation: remove attack_depth aspect

It's been removed from the AI.


  Commit: f00f9e3901265eefc679357e0be1fb7707d1343b
      https://github.com/wesnoth/wesnoth/commit/f00f9e3901265eefc679357e0be1fb7707d1343b
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M data/ai/utils/default_config.cfg

  Log Message:
  -----------
  RCA AI: remove attack_depth aspect from default configuration


  Commit: c0bc8c548c7bfed610ea28be304c444ec66c0879
      https://github.com/wesnoth/wesnoth/commit/c0bc8c548c7bfed610ea28be304c444ec66c0879
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M data/core/macros/ai.cfg
    M data/core/macros/utils.cfg

  Log Message:
  -----------
  AI: deprecate ai_depth related macros


  Commit: f901a0fd81ba7d5399a27d2fb8e2c9f5a659ef1a
      https://github.com/wesnoth/wesnoth/commit/f901a0fd81ba7d5399a27d2fb8e2c9f5a659ef1a
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M data/test/scenarios/ai/config/simple_aspect.cfg
    M data/test/scenarios/ai/modify/aspects.cfg

  Log Message:
  -----------
  Unit tests: change attack_depth to leader_value for aspect tests

attack_depth has been removed


  Commit: 073f70b0a632d754ebd2b01afcde721a8c1b4c47
      https://github.com/wesnoth/wesnoth/commit/073f70b0a632d754ebd2b01afcde721a8c1b4c47
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M data/_main.cfg
    M src/ai/configuration.cpp
    M src/ai/configuration.hpp

  Log Message:
  -----------
  AI: move default algorithm definition from C++ to WML

Among other things this now allows defining cores that have a different default AI.


  Commit: fcc22a36e20c61a3db79c812d2b059e282fe66c8
      https://github.com/wesnoth/wesnoth/commit/fcc22a36e20c61a3db79c812d2b059e282fe66c8
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  Command-line game: get default ai_algorithm from config

Do not use a hard-coded value set to the RCA AI.


  Commit: c731be58a97e4bafc9fe17138a70c210c09af3f2
      https://github.com/wesnoth/wesnoth/commit/c731be58a97e4bafc9fe17138a70c210c09af3f2
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-11-17 (Sat, 17 Nov 2018)

  Changed paths:
    M data/ai/ais/ai_default_rca.cfg
    M data/ai/ais/ai_experimental.cfg
    M data/ai/dev/ai_default_rca_alternate_recruiting.cfg
    M data/ai/dev/formula_ai.cfg
    M data/ai/dev/formula_ai_poisoning.cfg
    M src/ai/configuration.cpp
    M src/ai/configuration.hpp

  Log Message:
  -----------
  AI configuration: new optional parameter mp_rank=

This parameter determines in which order the available AIs are shown in the MP computer player selection menu. This can be used for eras, modifications or cores to change which AI is first in the list.


  Commit: afb394c4b1d9a2f3a1c44932939d3c9e7198f9aa
      https://github.com/wesnoth/wesnoth/commit/afb394c4b1d9a2f3a1c44932939d3c9e7198f9aa
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-12-02 (Sun, 02 Dec 2018)

  Changed paths:
    M data/_main.cfg
    M data/ai/ais/ai_default_rca.cfg
    M data/ai/ais/ai_experimental.cfg
    M data/ai/dev/ai_default_rca_alternate_recruiting.cfg
    M data/ai/dev/formula_ai.cfg
    M data/ai/dev/formula_ai_poisoning.cfg
    M data/ai/utils/default_config.cfg
    M data/campaigns/An_Orcish_Incursion/scenarios/04_Valley_of_Trolls.cfg
    M data/campaigns/An_Orcish_Incursion/scenarios/05_Linaera_the_Quick.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/01_The_Elves_Besieged.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/02_Blackwater_Port.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/03_The_Isle_of_Alduin.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/04_The_Bay_of_Pearls.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/05a_Muff_Malal_Peninsula.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/07_Crossroads.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/08_The_Princess_of_Wesnoth.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/09_The_Valley_of_Death.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/10_Gryphon_Mountain.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/11_The_Ford_of_Abez.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/12_Northern_Winter.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/13_The_Dwarven_Doors.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/14_Plunging_Into_the_Darkness.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/15_The_Lost_General.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/16_Hasty_Alliance.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/18_A_Choice_Must_Be_Made.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19a_Snow_Plains.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19b_Swamp_Of_Dread.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/20a_North_Elves.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/23_Test_of_the_Clans.cfg
    M data/campaigns/Heir_To_The_Throne/scenarios/24_Battle_for_Wesnoth.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter1/01_The_Uprooting.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/14_Human_Alliance.cfg
    M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/17_Breaking_the_Siege.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/01_At_the_East_Gate.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/03_Strange_Allies.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/04_Troll_Bridge.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/05_Invaders.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/06_High_Pass.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/07_Mages_and_Drakes.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/10_The_Siege_of_Kal_Kartha.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/11_The_Court_of_Karrag.cfg
    M data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/01_A_Summer_of_Storms.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/02_The_Fall.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/03_A_Harrowing_Escape.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04a_The_Swamp_of_Esten.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/04b_The_Midlands.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/06_Temple_in_the_Deep.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/08_Clearwater_Port.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/09_Fallen_Lich_Point.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/10_Sewer_of_Southbay.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/12_A_Final_Spring.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/13_Peoples_in_Decline.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/14_Rough_Landing.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17a_The_Dragon.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17b_Lizard_Beach.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17c_Troll_Hole.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/17d_Cursed_Isle.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/19_The_Vanguard.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/20_Return_of_the_Fleet.cfg
    M data/campaigns/The_Rise_Of_Wesnoth/scenarios/22_The_Rise_of_Wesnoth.cfg
    M data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg
    M data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg
    M data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg
    M data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg
    M data/campaigns/The_South_Guard/scenarios/06b_The_Long_March.cfg
    M data/campaigns/The_South_Guard/scenarios/08a_Return_to_Kerlath.cfg
    M data/core/macros/ai.cfg
    M data/core/macros/utils.cfg
    M data/multiplayer/scenarios/2p_Dark_Forecast.cfg
    M data/schema/ai/aspect_complex.cfg
    M data/schema/ai/aspect_simple.cfg
    M data/schema/ai/modify.cfg
    M data/test/scenarios/ai/config/simple_aspect.cfg
    M data/test/scenarios/ai/modify/aspects.cfg
    M src/ai/configuration.cpp
    M src/ai/configuration.hpp
    M src/ai/contexts.cpp
    M src/ai/contexts.hpp
    M src/ai/default/aspect_attacks.cpp
    M src/ai/formula/ai.cpp
    M src/ai/lua/core.cpp
    M src/ai/manager.cpp
    M src/ai/manager.hpp
    M src/ai/registry.cpp
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp
    M src/game_initialization/multiplayer.cpp
    M src/recall_list_manager.hpp

  Log Message:
  -----------
  Merge pull request #3723 from mattsc/rca_ai_changes

Default AI changes


Compare: https://github.com/wesnoth/wesnoth/compare/646e074e5dee...afb394c4b1d9
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

More information about the Commits mailing list