[wesnoth-commits] [wesnoth/wesnoth] c220cb: Fix #3794: dialog callback can be called immediate...

GitHub noreply at github.com
Sat Dec 22 05:14:35 UTC 2018


  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c220cb92ac75f4eddfeaa6287506ec677a7cc433
      https://github.com/wesnoth/wesnoth/commit/c220cb92ac75f4eddfeaa6287506ec677a7cc433
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-12-22 (Sat, 22 Dec 2018)

  Changed paths:
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  Fix #3794: dialog callback can be called immediately

When a dialog registered a new callback in the callback handler, the new
callback was called as a result of the same event that fired the original
handler.

The solution is to simply stop processing of the event after executing the
original handler.


  Commit: 91cfee47a2a30c21a6d571fd98d25c85c7a072c2
      https://github.com/wesnoth/wesnoth/commit/91cfee47a2a30c21a6d571fd98d25c85c7a072c2
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-12-22 (Sat, 22 Dec 2018)

  Changed paths:
    M changelog.md

  Log Message:
  -----------
  Changelog entry for commit c220cb92


Compare: https://github.com/wesnoth/wesnoth/compare/5692a62bb798...91cfee47a2a3
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Commits mailing list