[wesnoth-commits] [wesnoth/wesnoth] 8707a1: Cleaned up MSVC error suppression

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 8707a13a2f71e2fb2b7f1a3cad513e88cba192b4
      https://github.com/wesnoth/wesnoth/commit/8707a13a2f71e2fb2b7f1a3cad513e88cba192b4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M projectfiles/VC12/campaignd.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnothd.vcxproj
    M projectfiles/VC12/wesnothlib.vcxproj
    M src/ai/composite/ai.hpp
    M src/ai/composite/aspect.hpp
    M src/ai/composite/component.hpp
    M src/ai/composite/contexts.hpp
    M src/ai/composite/goal.hpp
    M src/ai/composite/rca.hpp
    M src/ai/composite/stage.hpp
    M src/ai/contexts.hpp
    M src/ai/default/aspect_attacks.hpp
    M src/ai/default/ca.hpp
    M src/ai/default/ca_move_to_targets.hpp
    M src/ai/default/contexts.hpp
    M src/ai/default/recruitment.cpp
    M src/ai/default/recruitment.hpp
    M src/ai/default/stage_rca.hpp
    M src/ai/formula/ai.hpp
    M src/ai/formula/engine_fai.cpp
    M src/ai/formula/stage_side_formulas.hpp
    M src/ai/formula/stage_unit_formulas.hpp
    M src/gettext_boost.cpp
    M src/global.hpp
    M src/server/simple_wml.cpp
    M src/terrain/translation.hpp

  Log Message:
  -----------
  Cleaned up MSVC error suppression

The following have been enabled. They no longer cause any errors or warnings.
* C4819
* C4355
* C4351
* C4345

The following has been disabled globally and will be handled in individual cases:
* C4996

The following have been moved to the project files (meaning they become global in
their respective projects):
* C4250 (in wesnoth)
* C4244 (in wesnoth, wesnoth-lib, wesnothd, and campaignd)

The following has been left alone since I don't build the unit tests:
* C4702


  Commit: 0213eaf76155be6c164052d7b460bd10753a3cbe
      https://github.com/wesnoth/wesnoth/commit/0213eaf76155be6c164052d7b460bd10753a3cbe
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M src/desktop/version.cpp
    M src/network_asio.cpp
    M src/wesnothd_connection.cpp

  Log Message:
  -----------
  Silence MSVC C4996 in specific cases


  Commit: 99a8427d41adc13cfe8e8c9c9fd78e55330abb61
      https://github.com/wesnoth/wesnoth/commit/99a8427d41adc13cfe8e8c9c9fd78e55330abb61
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M projectfiles/VC12/campaignd.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnothd.vcxproj

  Log Message:
  -----------
  Define _WINSOCK_DEPRECATED_NO_WARNINGS in VC projectfile

[ci skip]

Seems the definition in wesnothd_connection.hpp is insufficient if warning C4996
is enabled.


  Commit: db0f23701b1aa42a8c66bac96cbc163776e40606
      https://github.com/wesnoth/wesnoth/commit/db0f23701b1aa42a8c66bac96cbc163776e40606
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M projectfiles/VC12/wesnoth.vcxproj.filters

  Log Message:
  -----------
  VC Projfile: minor entry cleanup

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/bf8c1b90bf20...db0f23701b1a