[wesnoth-commits] [wesnoth/wesnoth] f96b9d: Promote ai_info_ from pointer to a member object

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f96b9d2bba00c4b176c79571365eb38c33842a18
      https://github.com/wesnoth/wesnoth/commit/f96b9d2bba00c4b176c79571365eb38c33842a18
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj.filters
    M src/ai/manager.cpp
    M src/ai/manager.hpp
    M src/ai/registry.cpp
    R src/ai/registry.hpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  Promote ai_info_ from pointer to a member object

We used to create a new ai_info object in the constructor of
playsingle_controller in order to reset it on scenario changes.
Now when the AI manager is a part of game state, resetting the game state
implicitly creates a new ai_info object, and setting the AI info manually
is no longer necessary.

This also ensures that ai_info can't ever be null, fixing #2522.

In the process, I also discovered that ai::registry::init() doesn't do
anything, so I removed it, its declaration, and ai/registry.hpp which
contained nothing except said function declaration.


  Commit: 7f91caf57f276a389506cd9bd6e6867c20cd8876
      https://github.com/wesnoth/wesnoth/commit/7f91caf57f276a389506cd9bd6e6867c20cd8876
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/wesnothd_connection.hpp

  Log Message:
  -----------
  Fix MVSC compiler warning about macro redefinition


Compare: https://github.com/wesnoth/wesnoth/compare/05d52c5db5aa...7f91caf57f27