[wesnoth-commits] [wesnoth/wesnoth] 4b6a74: Preferences Dialog: consolidate helpers together a...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4b6a74b6f58e9eae030298d7a04dd19df89dde36
      https://github.com/wesnoth/wesnoth/commit/4b6a74b6f58e9eae030298d7a04dd19df89dde36
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-24 (Sat, 24 Feb 2018)

  Changed paths:
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  Preferences Dialog: consolidate helpers together and apply minor cleanup

* Made use of utils::clamp
* No need to take a const ref of just an int


  Commit: f722a09730118ef0c51896b0d2ec95c37f8dfc49
      https://github.com/wesnoth/wesnoth/commit/f722a09730118ef0c51896b0d2ec95c37f8dfc49
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-24 (Sat, 24 Feb 2018)

  Changed paths:
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/preferences_dialog.hpp

  Log Message:
  -----------
  Preferences Dialog: made sound setting changes apply immediately (fixes #1766)


  Commit: cc3d73621a7d064b7d50b3526b7b41167ec1dafa
      https://github.com/wesnoth/wesnoth/commit/cc3d73621a7d064b7d50b3526b7b41167ec1dafa
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-24 (Sat, 24 Feb 2018)

  Changed paths:
    M data/gui/window/preferences/01_general.cfg
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  Preferences Dialog: avoid offset-by-one handling for accl speeds

Since the slider values started at 1, they needed to be adjusted for speed
index access. Less confusing to start at 0.


Compare: https://github.com/wesnoth/wesnoth/compare/b5ec7b832e34...cc3d73621a7d