[wesnoth-commits] [wesnoth/wesnoth] dfa868: Revert "Editor/Context Manager: no need to use an ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dfa8682598dfdf2e8cb0972bbd22a560b72eff15
      https://github.com/wesnoth/wesnoth/commit/dfa8682598dfdf2e8cb0972bbd22a560b72eff15
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-02-24 (Sat, 24 Feb 2018)

  Changed paths:
    M src/editor/map/context_manager.cpp
    M src/editor/map/context_manager.hpp

  Log Message:
  -----------
  Revert "Editor/Context Manager: no need to use an rvalue reference just to swap"

This reverts commit 106a1d5c0527b7623b0f169322aed6335519bc17.

It's confusing if the function changes the passed pointer to point to a
different map context without warning. Passing the pointer as a rvalue
reference warns the caller that the pointer will be modified.