[Commits] [wesnoth/wesnoth] 5ec8d6: Create savegame filenames with the same code as in...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5ec8d630edf337ed34dc7447062562db66afac7a
      https://github.com/wesnoth/wesnoth/commit/5ec8d630edf337ed34dc7447062562db66afac7a
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M src/hotkey/hotkey_handler.cpp
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  Create savegame filenames with the same code as in actual saving

Follow-up to commit 057a53055f74348c56d97c2c7ae0ab11a71b88cd.

Otherwise, Menu -> Back to... would be broken whenever the logic differs
between that feature and actual saving.


  Commit: d2748dc4259fa6f493c5d08ec71c3140565231d4
      https://github.com/wesnoth/wesnoth/commit/d2748dc4259fa6f493c5d08ec71c3140565231d4
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-02-07 (Wed, 07 Feb 2018)

  Changed paths:
    M changelog
    M players_changelog
    M src/save_index.cpp
    M src/save_index.hpp
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  Quit pretending that underscores in savefile names are actually spaces

The code was frantically converting spaces to underscores and back to keep
the facade up, and sometimes it failed (#1567).

The solution is obvious: simply use spaces for real in savefile names.
This way the conversion is only needed in one place (when generating the
suggested filename).

Fixes #1567. As a minor bonus, this also makes the "save game" dialog show
the filename with spaces.


Compare: https://github.com/wesnoth/wesnoth/compare/39c3f21b9b13...d2748dc4259f