[Commits] [wesnoth/wesnoth] 5ed381: campaignd: Reject empty passphrases

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5ed3810bd588ef7162ffad6ca5128100525f4542
      https://github.com/wesnoth/wesnoth/commit/5ed3810bd588ef7162ffad6ca5128100525f4542
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2018-02-11 (Sun, 11 Feb 2018)

  Changed paths:
    M changelog
    M src/campaign_server/campaign_server.cpp

  Log Message:
  -----------
  campaignd: Reject empty passphrases

Fixes issue #2444.

Clients may send an empty passphrase, especially if they do not do as
the mainline client and generate a random one to substitute in the .pbl.
An empty string is still hashable, but the server is really not supposed
to allow an empty passphrase so we should just reject those. It's also a
good warning sign against broken clients -- like wesnoth_addon_manager
right now.