[Commits] [wesnoth/wesnoth] 30d8bf: Fix: canceling attempt to reconnect didn't close a...

[GitHub]

  Branch: refs/heads/close-connection-on-cancel
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 30d8bf75bb6cfdbaeca7b8aa0dc1bdb482247f32
      https://github.com/wesnoth/wesnoth/commit/30d8bf75bb6cfdbaeca7b8aa0dc1bdb482247f32
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-10 (Wed, 10 Jan 2018)

  Changed paths:
    M src/addon/client.cpp
    M src/addon/client.hpp
    M src/addon/manager_ui.cpp
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Fix: canceling attempt to reconnect didn't close addon manager

Only happened if the player used the buttons in the addon list: the buttons
in the right panel worked fine. The problem was that the addon list caught
the addons_client::user_exit exception separately and didn't rethrow it
when necessary, unlike the addon manager itself.

I decided to simply throw a different exception instead.