[Commits] [wesnoth/wesnoth] 745f8d: Fix kban syntax error

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 745f8d29c3fb0aaf8f24351dc98f6f77291c27af
      https://github.com/wesnoth/wesnoth/commit/745f8d29c3fb0aaf8f24351dc98f6f77291c27af
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/player_info.cpp

  Log Message:
  -----------
  Fix kban syntax error

The "Kick + Ban" button omitted the space between the command and the nick.


  Commit: 88545de4b07b89775ed291c08750dc128ec1643e
      https://github.com/wesnoth/wesnoth/commit/88545de4b07b89775ed291c08750dc128ec1643e
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/server/ban.cpp
    M src/server/ban.hpp
    M src/server/server.cpp
    M src/server/server.hpp
    M src/server/server_base.hpp

  Log Message:
  -----------
  Expire the ban when no longer needed.

Actually, we expire it just before checking for bans during login and for the /q bans (list current bans) command.


  Commit: 66f740840ee5fc5de559f27506538fca9ed36e93
      https://github.com/wesnoth/wesnoth/commit/66f740840ee5fc5de559f27506538fca9ed36e93
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/server/server.cpp
    M src/server/server_base.cpp
    M src/server/server_base.hpp

  Log Message:
  -----------
  Implement max connections

The function was lost. Recovered from Git hitsory and cleaned up a bit.


  Commit: d9f9d83a6bbccc37dc4ec4e5d466cea50233543b
      https://github.com/wesnoth/wesnoth/commit/d9f9d83a6bbccc37dc4ec4e5d466cea50233543b
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/game_launcher.cpp
    M src/server/server_base.cpp
    M src/wesnothd_connection_error.hpp

  Log Message:
  -----------
  Stop hanging when banned

When a banned or connection-limited client attempts to log in, it hangs.

This is because the client does not understand that the server did not finish the handshake. This moves the check to a point just after the handshake has completed (when the server would normally ask for a version number). The client never checked for errors, so added a check.


  Commit: ef0c3b615d2e7e1583c46be7853c9d15f7b59cb9
      https://github.com/wesnoth/wesnoth/commit/ef0c3b615d2e7e1583c46be7853c9d15f7b59cb9
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  Implement kickban

Added the missing call to actually ban the IP before kicking the player.


  Commit: 5426c884dd700fe5dd36dbbffe45ece7886cd08a
      https://github.com/wesnoth/wesnoth/commit/5426c884dd700fe5dd36dbbffe45ece7886cd08a
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/server/ban.cpp
    M src/server/ban.hpp

  Log Message:
  -----------
  Persist bans

The bans were not being immediately written to the file when created or removed.

Note that the file is overwritten directly rather than saved to a temporary and moved into place. This creates a race condition: a crash while writing corrupts the file.


  Commit: fbc0a142b0d3b5c8595ebe89e38182d85ec10ee0
      https://github.com/wesnoth/wesnoth/commit/fbc0a142b0d3b5c8595ebe89e38182d85ec10ee0
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2018-01-03 (Wed, 03 Jan 2018)

  Changed paths:
    M src/server/server_base.cpp

  Log Message:
  -----------
  Send handshake in network byte order

The handshake value is 42. The server sends this on startup in response to a zero-length document.

Yes, that means the server replies with The Answer to The Ultimate Question of Life, the Universe, and Everything. It is unspecified whether the client properly interprets The Answer.


  Commit: ed6ad71f486a36b0ed2644e52036883199b67af3
      https://github.com/wesnoth/wesnoth/commit/ed6ad71f486a36b0ed2644e52036883199b67af3
  Author: Sergey Popov <loonycyborg at gmail.com>
  Date:   2018-01-12 (Fri, 12 Jan 2018)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/game_launcher.cpp
    M src/gui/dialogs/multiplayer/player_info.cpp
    M src/server/ban.cpp
    M src/server/ban.hpp
    M src/server/server.cpp
    M src/server/server.hpp
    M src/server/server_base.cpp
    M src/server/server_base.hpp
    M src/wesnothd_connection_error.hpp

  Log Message:
  -----------
  Merge pull request #2329 from GregoryLundberg/GL_I2327

Implement MP Moderation


Compare: https://github.com/wesnoth/wesnoth/compare/8ae99bc86abf...ed6ad71f486a