[Commits] [wesnoth/wesnoth] b779c9: Display Context: enable bounds checking for get_te...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b779c91df7ddddbfeb119a0faa60a08bfb94516c
      https://github.com/wesnoth/wesnoth/commit/b779c91df7ddddbfeb119a0faa60a08bfb94516c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-28 (Sun, 28 Jan 2018)

  Changed paths:
    M src/display_context.cpp
    M src/game_board.hpp

  Log Message:
  -----------
  Display Context: enable bounds checking for get_team()

Also enabled it for the non-const version in game_board.


  Commit: 229b9be7eb590b80ae053bf97585f10d38d55f5e
      https://github.com/wesnoth/wesnoth/commit/229b9be7eb590b80ae053bf97585f10d38d55f5e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-28 (Sun, 28 Jan 2018)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  Play Controller: removed useless optimization


  Commit: e19b19bf425f9c22b8e5ea916c50dc72311f75a0
      https://github.com/wesnoth/wesnoth/commit/e19b19bf425f9c22b8e5ea916c50dc72311f75a0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-28 (Sun, 28 Jan 2018)

  Changed paths:
    M src/game_board.cpp
    M src/game_state.cpp
    M src/pathfind/pathfind.cpp
    M src/side_filter.cpp

  Log Message:
  -----------
  Made more use of get_team() and its bounds checking


  Commit: 626d4137984c83e9fe2c3c776ce3c8e39341ce0b
      https://github.com/wesnoth/wesnoth/commit/626d4137984c83e9fe2c3c776ce3c8e39341ce0b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-28 (Sun, 28 Jan 2018)

  Changed paths:
    M src/editor/map/context_manager.cpp
    M src/editor/map/context_manager.hpp

  Log Message:
  -----------
  Editor/Context Manager: cleaned up context refresh code

This used to need to be a class of its own in order to store some info prior to switching
the context, but that's not the case anymore. Moved map_context_refresher::refresh into
context_manager. Also moved the set_window_title call into the function as well, since it
was called in all three places the context refresher was used.


  Commit: e52bd6eba77fb21acab7a5d17c7acdda2cf84c5e
      https://github.com/wesnoth/wesnoth/commit/e52bd6eba77fb21acab7a5d17c7acdda2cf84c5e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-28 (Sun, 28 Jan 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/faction_select.cpp

  Log Message:
  -----------
  Faction Select: allow dialog to be closed with ESC (fixes #2404)

I had probably added this before since I wanted a player joining a game to always choose
a leader, but that's rather mitigated by the fact that there's a cancel button.


Compare: https://github.com/wesnoth/wesnoth/compare/24e40cc0b18a...e52bd6eba77f