[wesnoth-commits] [wesnoth/wesnoth] 787a1a: wesnothd: fix prematurely adding new players to ga...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 787a1a0dae41e68d237cacd9ceca381d6dad76df
      https://github.com/wesnoth/wesnoth/commit/787a1a0dae41e68d237cacd9ceca381d6dad76df
  Author: loonycyborg <loonycyborg at gmail.com>
  Date:   2018-06-06 (Wed, 06 Jun 2018)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  wesnothd: fix prematurely adding new players to games_and_users_list_

If dc happens during asio read that would call server::add_player
then a "ghost" player will appear in games_and_users_list_. Fix works by
moving the list update into the handler, it will be called only if read is
successful.

This should prevent issue #2989 unless it has some other mechanism



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.