[wesnoth-commits] [wesnoth/wesnoth] ef9a87: Fixed MP admins being unable to observe private ga...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ef9a87bf36f43a182216f86cc947c1e0a94d9de3
      https://github.com/wesnoth/wesnoth/commit/ef9a87bf36f43a182216f86cc947c1e0a94d9de3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M changelog.md
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  Fixed MP admins being unable to observe private games (fixes #2851)

This was due to the change in the MP initialization process wherein the lobby wouldn't
show up until the initial gamelist was received. Since the admin auth message is sent
after [join_game] and before the initial gamelist, and the chatbox widget handled parsing
the auth message, the client was never marked as authenticated and therefor couldn't
observe private games. This fixes that by adding auth parsing to the MP initialization
process.

Note this doesn't fix the issue of the auth confirmation not showing up in the lobby chat
(issue #2920). I'll have to think of a way to fix that separately.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.