[wesnoth-commits] [wesnoth/wesnoth] e8bd3c: GUI2/Menu Button: store selected index as an unsig...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e8bd3c26d2dfaed83edb5f66b55b3ddaa5004911
      https://github.com/wesnoth/wesnoth/commit/e8bd3c26d2dfaed83edb5f66b55b3ddaa5004911
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: store selected index as an unsigned int

Also initialized it to 0 in the ctor instead of relying on that being set
via set_values().


  Commit: f95dc40f132afb79432d4a73db88406b5c5e7b9d
      https://github.com/wesnoth/wesnoth/commit/f95dc40f132afb79432d4a73db88406b5c5e7b9d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/multimenu_button.cpp

  Log Message:
  -----------
  Cleaned up two emplace_back calls


  Commit: 23740ea3cfd625a6e4c0ab2575db0d1c6f247ff4
      https://github.com/wesnoth/wesnoth/commit/23740ea3cfd625a6e4c0ab2575db0d1c6f247ff4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2/Multimenu Button: store max shown count as an unsigned int

A negative count here makes no sense...


  Commit: f54b3f722515c94a96d8ba1694e65ae4697c1c01
      https://github.com/wesnoth/wesnoth/commit/f54b3f722515c94a96d8ba1694e65ae4697c1c01
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/multimenu_button.cpp

  Log Message:
  -----------
  GUI2/Multimenu Button: fixed maximum_shown defaulting to 0 instead of 1

Fixes the campaign selection dialog's modification dropdown saying "1 other" for
the first mod you select.


Compare: https://github.com/wesnoth/wesnoth/compare/3526aa8e86ee...f54b3f722515
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.