[wesnoth-commits] [wesnoth/wesnoth] b0d0dd: Fixup unused parameter

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b0d0dd3cb5971447f9b415296d6e796038834ebb
      https://github.com/wesnoth/wesnoth/commit/b0d0dd3cb5971447f9b415296d6e796038834ebb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/faction_select.cpp

  Log Message:
  -----------
  Fixup unused parameter


  Commit: 16d254f1316a0de9618c3cc44e6507e114b9ef74
      https://github.com/wesnoth/wesnoth/commit/16d254f1316a0de9618c3cc44e6507e114b9ef74
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: store selected index as an unsigned int

Also initialized it to 0 in the ctor instead of relying on that being set
via set_values().


  Commit: ec0499221a1d11842199adbb691a4ad945788410
      https://github.com/wesnoth/wesnoth/commit/ec0499221a1d11842199adbb691a4ad945788410
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/multimenu_button.cpp

  Log Message:
  -----------
  Cleaned up two emplace_back calls


  Commit: b17ade9f9c795027fb38c23c65ce586e3a7cc0c8
      https://github.com/wesnoth/wesnoth/commit/b17ade9f9c795027fb38c23c65ce586e3a7cc0c8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2/Multimenu Button: store max shown count as an unsigned int

A negative count here makes no sense...


  Commit: 73627767db59342f46c5c6b792aab452c9502696
      https://github.com/wesnoth/wesnoth/commit/73627767db59342f46c5c6b792aab452c9502696
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-16 (Sat, 16 Jun 2018)

  Changed paths:
    M src/gui/widgets/multimenu_button.cpp

  Log Message:
  -----------
  GUI2/Multimenu Button: fixed maximum_shown defaulting to 0 instead of 1

Fixes the campaign selection dialog's modification dropdown saying "1 other" for
the first mod you select.


Compare: https://github.com/wesnoth/wesnoth/compare/12671fa71576...73627767db59
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.