[wesnoth-commits] [wesnoth/wesnoth] cdc8da: wesnothd: Fix lobby messages and whispers not bein...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cdc8da25aea2cbc055dc12879d2c4333fecfc3e1
      https://github.com/wesnoth/wesnoth/commit/cdc8da25aea2cbc055dc12879d2c4333fecfc3e1
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M changelog.md
    M src/server/server.cpp

  Log Message:
  -----------
  wesnothd: Fix lobby messages and whispers not being truncated as they should

For lobby messages, there was a length cap in place already, but the
truncated message was lost in processing because it ended up in a WML
document that isn't the one relayed to listening clients.

On the other hand, whisper messages were missing the truncate logic
entirely. Oops.

(The logic for in-game messages does truncate messages correctly as far
as I can tell, and additionally the client UI doesn't allow overlong
messages.)

Thanks to Soliton for pointing me towards the faulty code.


  Commit: 6b2ca320261326d7862d3fe52f395e83913f9c6d
      https://github.com/wesnoth/wesnoth/commit/6b2ca320261326d7862d3fe52f395e83913f9c6d
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2018-06-18 (Mon, 18 Jun 2018)

  Changed paths:
    M changelog.md

  Log Message:
  -----------
  U does not precede G in the English alphabet

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/be41a692fb44...6b2ca3202613
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.