[wesnoth-commits] [wesnoth/wesnoth] cd3f7f: Revert "Fixup c3ed9d2"

GitHub noreply at github.com
Sat Jun 23 05:30:15 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cd3f7fd8e92daacace55baaa04c097e2931c012b
      https://github.com/wesnoth/wesnoth/commit/cd3f7fd8e92daacace55baaa04c097e2931c012b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M src/gui/auxiliary/iterator/policy_order.hpp

  Log Message:
  -----------
  Revert "Fixup c3ed9d2"

This reverts commit 39efb7a2e4a28bff0f3b90a45aea8031b8cf7348.


  Commit: 1778dd858179f954dade9f44cacea26bddf84950
      https://github.com/wesnoth/wesnoth/commit/1778dd858179f954dade9f44cacea26bddf84950
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M src/gui/auxiliary/iterator/policy_order.hpp

  Log Message:
  -----------
  Actually fixup c3ed9d2bc7d9


  Commit: 1eaa51b3f9033723ac5f18d65d25780d761c2ae7
      https://github.com/wesnoth/wesnoth/commit/1eaa51b3f9033723ac5f18d65d25780d761c2ae7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M src/gui/auxiliary/iterator/iterator.hpp

  Log Message:
  -----------
  GUI2/Iterator: added some alias templates and a get() function


  Commit: aca7d4e6df4648ff45f48b6acb9e643de8c05103
      https://github.com/wesnoth/wesnoth/commit/aca7d4e6df4648ff45f48b6acb9e643de8c05103
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-23 (Sat, 23 Jun 2018)

  Changed paths:
    M src/gui/dialogs/select_orb_colors.cpp

  Log Message:
  -----------
  Select Orb Colors: used a widget iterator instead of a walker

The documentation indicates you're not really meant to use the walker directly.
They're part of the implementation of the iterators. They could be used directly,
as shown here, but this is shorter.


Compare: https://github.com/wesnoth/wesnoth/compare/39efb7a2e4a2...aca7d4e6df46
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Commits mailing list