[wesnoth-commits] [wesnoth/wesnoth] dd6910: Removed scaling algorithm customization

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dd69107c9b03017ccf2eb586dfbee158f816659d
      https://github.com/wesnoth/wesnoth/commit/dd69107c9b03017ccf2eb586dfbee158f816659d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-25 (Mon, 25 Jun 2018)

  Changed paths:
    M changelog.md
    M data/advanced_preferences.cfg
    R data/gui/window/advanced_graphics_options.cfg
    M projectfiles/VC14/wesnoth.vcxproj
    M projectfiles/VC14/wesnoth.vcxproj.filters
    M source_lists/wesnoth
    R src/gui/dialogs/advanced_graphics_options.cpp
    R src/gui/dialogs/advanced_graphics_options.hpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/image.cpp
    M src/image.hpp
    M src/tests/gui/test_gui2.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Removed scaling algorithm customization

We're going to be using NN scaling for the map, and that's already handled automatically
by SDL (and in the future, OGL). We don't need these settings for surface SCALED_TO_ZOOM
and SCALED_TO_HEX scaling. In any case, if we want to scale a surface to zoom or hex, it
will almost certainly be for map rendering (such scaling methods don't make sense in the
UI, for example), so just defaulting to NN is simplest.

As for why I've decided to stick with nearest-neighbor scaling for zoom, it happens to look
a lot better when done on the GPU than on the CPU for some reason (perhaps having to do with
the old rendering pipeline in which we were doing surface scaling), and it's better to have
a consistent scaling look as you zoom in, especially if we wanted to do animated zoom-ins.

This change drops the option to use Linear or xBRZ scaling for map zooming. This was already
the practical case due to me converting map rendering to use textures. NN was used for all
zoom levels, and it's fast and looks good.


  Commit: 862b086ba9d43edb87362bbf4b7f75355eb50955
      https://github.com/wesnoth/wesnoth/commit/862b086ba9d43edb87362bbf4b7f75355eb50955
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-06-25 (Mon, 25 Jun 2018)

  Changed paths:
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  Fixup tests for 4eee386


Compare: https://github.com/wesnoth/wesnoth/compare/feb99c384a3d...862b086ba9d4
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.