[wesnoth-commits] [wesnoth/wesnoth] 461cd2: Themes: Fix the observers icon being hidden under ...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 461cd2c4bdeb2eb0e84ede6e57cd0b315dee2cee
      https://github.com/wesnoth/wesnoth/commit/461cd2c4bdeb2eb0e84ede6e57cd0b315dee2cee
  Author: josteph <josteph at fastmail.com>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M data/themes/default.cfg

  Log Message:
  -----------
  Themes: Fix the observers icon being hidden under the minimap

Closes #3543. Fixups #3441.

The observers icon is declared immediately after `report_timeout`,
therefore the timeout widget was the ref rect for the observers widget:
https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120

PR #3441 added a battery icon to the left of the timeout widget. That
shifted the timeout widget to the right and the observers widget shifted
along with it due to its relative positioning. The observers widget
moved even on devices that didn't have a battery.

Fix this by using the battery box as the ref of the observers widget,
because it currently occupies the absolute location the observers widget
was positioned relatively to.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.