[wesnoth-commits] [wesnoth/wesnoth] 77fc45: Remove sample_user_handler.

[Pentarctagon]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 77fc455b0b995c1a5f04ffda43d75c03e08eb460
      https://github.com/wesnoth/wesnoth/commit/77fc455b0b995c1a5f04ffda43d75c03e08eb460
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M source_lists/wesnothd
    R src/server/sample_user_handler.cpp
    R src/server/sample_user_handler.hpp
    M src/server/server.cpp

  Log Message:
  -----------
  Remove sample_user_handler.

While I understand the reason it's here, it's been over a decade, no other user handlers have been added, and there's no indication any others will be added. Therefore, it doesn't seem like there's much of a reason to keep this code around.


  Commit: 4a93de4b00236d0970509cf1b336d58be42d602b
      https://github.com/wesnoth/wesnoth/commit/4a93de4b00236d0970509cf1b336d58be42d602b
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/server/server.cpp
    M src/server/server.hpp

  Log Message:
  -----------
  Remove uh_name_ variable.

This is unneeded, as the only user handler is the forum/db handler.


  Commit: 0870d1bc897838219495e53996ccf98bd35c480b
      https://github.com/wesnoth/wesnoth/commit/0870d1bc897838219495e53996ccf98bd35c480b
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/server/forum_user_handler.cpp
    M src/server/forum_user_handler.hpp
    M src/server/server.cpp
    M src/server/user_handler.cpp
    M src/server/user_handler.hpp

  Log Message:
  -----------
  Remove unused email-related functions.


  Commit: eef0c34b0e18c9ec44d690a48d6c2ec16837c1dd
      https://github.com/wesnoth/wesnoth/commit/eef0c34b0e18c9ec44d690a48d6c2ec16837c1dd
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/server/forum_user_handler.cpp
    M src/server/forum_user_handler.hpp
    M src/server/server.cpp
    M src/server/user_handler.hpp

  Log Message:
  -----------
  Removes unused/unimplemented nickserv functionality.

Commands removed:
* register
* set
* details
* drop


  Commit: 25f1537003bd9ceacd273c034ec130c1a9e7e4d0
      https://github.com/wesnoth/wesnoth/commit/25f1537003bd9ceacd273c034ec130c1a9e7e4d0
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/server/forum_user_handler.hpp
    M src/server/server.cpp
    M src/server/user_handler.hpp

  Log Message:
  -----------
  Remove the user_handler's clean_up() method.

It doesn't do anything.


  Commit: b1e92206f5dccfd06dd0261696c8fdf259a760d1
      https://github.com/wesnoth/wesnoth/commit/b1e92206f5dccfd06dd0261696c8fdf259a760d1
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/server/server.cpp
    M src/server/server.hpp

  Log Message:
  -----------
  Remove the tracking of the last user handler clean.

The information isn't used, and the method is never actually called.


  Commit: 72e203844efa0901075b597bc01a0deecf716f4f
      https://github.com/wesnoth/wesnoth/commit/72e203844efa0901075b597bc01a0deecf716f4f
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/server/server.cpp

  Log Message:
  -----------
  Fix unused variable warning.


  Commit: 282efeae864a3871e13164981a741371349ea5f0
      https://github.com/wesnoth/wesnoth/commit/282efeae864a3871e13164981a741371349ea5f0
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2019-08-22 (Thu, 22 Aug 2019)

  Changed paths:
    M src/chat_command_handler.cpp
    M src/chat_command_handler.hpp

  Log Message:
  -----------
  Remove client-side nickserv command functionality.


Compare: https://github.com/wesnoth/wesnoth/compare/2144642d6d3c...282efeae864a