[wesnoth-commits] [wesnoth/wesnoth] 5902e1: Adds a preference item for a sound being played an...

[Wedge009]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5902e1116cecb331456375b0569a0d1d90291489
      https://github.com/wesnoth/wesnoth/commit/5902e1116cecb331456375b0569a0d1d90291489
  Author: ville <lilinitsy at gmail.com>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M data/gui/window/mp_alerts_options.cfg
    M src/game_config.cpp
    M src/game_config.hpp
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/mp_ui_alerts.cpp
    M src/mp_ui_alerts.hpp

  Log Message:
  -----------
  Adds a preference item for a sound being played and desktop notifications in the lobby when a new game is created.

Remove unnecessary blank lines and debugging comments

- Adds a preferences entry in the multiplayer/alerts menu so sounds and desktop notifications can be toggled.

Reformat a few points for consistency

Have desktop notification show name and scenario of new game

Have desktop notification show name and scenario of new game

Update desktop notifications to use VGETTEXT for translations

(cherry picked from commit af71dbf1b1caec0ac654180cca9c037955602301)


  Commit: c803517ce3d478170e16694d76a7e89cfa9510c5
      https://github.com/wesnoth/wesnoth/commit/c803517ce3d478170e16694d76a7e89cfa9510c5
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M data/game_config.cfg
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/mp_ui_alerts.cpp
    M src/mp_ui_alerts.hpp

  Log Message:
  -----------
  Address comments against #3246 in order to resolve #2016.

* Remove unused notify_mode.NOTIFY_COUNT.
* Remove obsolete comment against mp_ui_alerts::items.
* Remove unused is_lobby parameter in mp_ui_alerts::game_created().
* Synchronise game_created sound in game_config.cfg with game_config.cpp.


  Commit: 8863f5370b4b73765cd129693bd9420ab8442119
      https://github.com/wesnoth/wesnoth/commit/8863f5370b4b73765cd129693bd9420ab8442119
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M data/game_config.cfg
    M src/game_config.cpp

  Log Message:
  -----------
  Change game_created event sound to join.wav on @stevecotton's suggestion.


  Commit: 9f404710990b269db7a0e40c2f7c4f3abc9302ad
      https://github.com/wesnoth/wesnoth/commit/9f404710990b269db7a0e40c2f7c4f3abc9302ad
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/mp_ui_alerts.cpp

  Log Message:
  -----------
  Remove trailing white-space.

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/17ca8c354358...9f404710990b