[wesnoth-commits] [wesnoth/wesnoth] c4ffad: fix #1492 replays not saved in campaigns

[gfgtdf]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c4ffade49aa4efc2a410e031539a791c005c3b30
      https://github.com/wesnoth/wesnoth/commit/c4ffade49aa4efc2a410e031539a791c005c3b30
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/server/game.cpp
    M src/server/server.cpp

  Log Message:
  -----------
  fix #1492 replays not saved in campaigns

previously the clint woudl send a [update_game] to the
server before sending [store_next_scenario] whcih set
game::started_ to false and this disabled game::save_replay()

Now we instead set started_ to false after save_replay() is called

I also don't really see the point of calling update_side_data()
and describe_slots() before the new level data is available so i just
removed these calls. (the call to game::update_game())