[wesnoth-commits] [wesnoth/wesnoth] 169cff: Adds a preference item for a sound being played an...

[Wedge009]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 169cff9ec7ba1f654e2bccf6926d6c5f817727a3
      https://github.com/wesnoth/wesnoth/commit/169cff9ec7ba1f654e2bccf6926d6c5f817727a3
  Author: ville <lilinitsy at gmail.com>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M data/gui/window/mp_alerts_options.cfg
    M src/game_config.cpp
    M src/game_config.hpp
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/mp_ui_alerts.cpp
    M src/mp_ui_alerts.hpp

  Log Message:
  -----------
  Adds a preference item for a sound being played and desktop notifications in the lobby when a new game is created.

Remove unnecessary blank lines and debugging comments

- Adds a preferences entry in the multiplayer/alerts menu so sounds and desktop notifications can be toggled.

Reformat a few points for consistency

Have desktop notification show name and scenario of new game

Have desktop notification show name and scenario of new game

Update desktop notifications to use VGETTEXT for translations

(cherry picked from commit af71dbf1b1caec0ac654180cca9c037955602301)
(cherry picked from commit a2d994328669499549a614753781ba9cabcfa41d)


  Commit: e4e260709a7618042e771fc089c7a2b367175a3f
      https://github.com/wesnoth/wesnoth/commit/e4e260709a7618042e771fc089c7a2b367175a3f
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M data/game_config.cfg
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/mp_ui_alerts.cpp
    M src/mp_ui_alerts.hpp

  Log Message:
  -----------
  Address comments against #3246 in order to resolve #2016.

* Remove unused notify_mode.NOTIFY_COUNT.
* Remove obsolete comment against mp_ui_alerts::items.
* Remove unused is_lobby parameter in mp_ui_alerts::game_created().
* Synchronise game_created sound in game_config.cfg with game_config.cpp.

(cherry picked from commit abaa77f7c6ca5a7b02ca9dc5b8bb52159bbcb4c9)


  Commit: 9dd6f70c98b82580fbfa5d35119cfb6e9ef68b71
      https://github.com/wesnoth/wesnoth/commit/9dd6f70c98b82580fbfa5d35119cfb6e9ef68b71
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M data/game_config.cfg
    M src/game_config.cpp

  Log Message:
  -----------
  Change game_created event sound to join.wav on @stevecotton's suggestion.


  Commit: 2ed6803aef660946cfe009ef46ab99a304371b1e
      https://github.com/wesnoth/wesnoth/commit/2ed6803aef660946cfe009ef46ab99a304371b1e
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/mp_ui_alerts.cpp

  Log Message:
  -----------
  Remove trailing white-space.

[ci skip]


  Commit: ff772b1be828e93e788a8dd4103a692150728116
      https://github.com/wesnoth/wesnoth/commit/ff772b1be828e93e788a8dd4103a692150728116
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M data/schema/core/config.cfg

  Log Message:
  -----------
  Add game_created sound key

See #4260 for details.

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/14f69f8ad412...ff772b1be828