[wesnoth-commits] [wesnoth/wesnoth] c5c93b: Fix wmlparser3 creation unnecessary attributes

[Lovens Weche]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c5c93b6611215ec3b5778ebfbb364a834815ebd7
      https://github.com/wesnoth/wesnoth/commit/c5c93b6611215ec3b5778ebfbb364a834815ebd7
  Author: Lovens Weche <lweche159 at gmail.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M data/tools/wesnoth/wmlparser3.py

  Log Message:
  -----------
  Fix wmlparser3 creation unnecessary attributes

In the wml parser, when a node creation spans multiple lines, the code
doesn’t take in account that one of those line can contain a
 #textdomain directive.

In the method “parse_outside_strings” (line 501), the code that
processes the #textdomain directive is inside an if block that is true
only if the node creation doesn’t span across multiple lines
(self.temp_key_nodes is null).

The solution implemented is that in the method “parse_outside_strings”
(line 501), the code that check if a line starts with #textdomain is
moved from inside the block that is true only if the node creation
doesn’t span across multiple lines and put in the method scope after
the first if block that checks if the line is empty.


  Commit: 515a3d66261676e7550d5c48932773ab1bfdf704
      https://github.com/wesnoth/wesnoth/commit/515a3d66261676e7550d5c48932773ab1bfdf704
  Author: Lovens Weche <lweche159 at gmail.com>
  Date:   2019-02-12 (Tue, 12 Feb 2019)

  Changed paths:
    M data/tools/wesnoth/wmlparser3.py

  Log Message:
  -----------
  Merge pull request #3910 from LovCAPONE/bug_3862_fix_proper

Fix wmlparser3 creation unnecessary attributes.


Compare: https://github.com/wesnoth/wesnoth/compare/f61856ff4f49...515a3d662616