[wesnoth-commits] [wesnoth/wesnoth] 067199: gui2/addon_connect: Use icon button for Help

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 06719958da3ad761065bab650aa13d621463d61e
      https://github.com/wesnoth/wesnoth/commit/06719958da3ad761065bab650aa13d621463d61e
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-17 (Sun, 17 Nov 2019)

  Changed paths:
    M data/gui/window/addon_connect.cfg

  Log Message:
  -----------
  gui2/addon_connect: Use icon button for Help

[ci skip]


  Commit: b56bf27604a35797f685402090f1cf2fe735db68
      https://github.com/wesnoth/wesnoth/commit/b56bf27604a35797f685402090f1cf2fe735db68
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-17 (Sun, 17 Nov 2019)

  Changed paths:
    M data/gui/window/game_save.cfg

  Log Message:
  -----------
  gui2/game_save: Give the OK button a custom label

[ci skip]


  Commit: 78df5c305ee3d5824dbcd7786f6dc7df7556427f
      https://github.com/wesnoth/wesnoth/commit/78df5c305ee3d5824dbcd7786f6dc7df7556427f
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-17 (Sun, 17 Nov 2019)

  Changed paths:
    M src/gui/dialogs/edit_text.cpp
    M src/gui/dialogs/edit_text.hpp

  Log Message:
  -----------
  gui2/edit_text: Add an option to disallow whitespace-only input


  Commit: f136bb9ef3ac5ecc51241e06e2c72f9ce7c8dbfb
      https://github.com/wesnoth/wesnoth/commit/f136bb9ef3ac5ecc51241e06e2c72f9ce7c8dbfb
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-17 (Sun, 17 Nov 2019)

  Changed paths:
    M data/gui/window/mp_connect.cfg
    R data/gui/window/mp_server_list.cfg
    M src/game_launcher.cpp
    M src/gui/dialogs/multiplayer/mp_connect.cpp
    M src/gui/dialogs/multiplayer/mp_connect.hpp
    M src/gui/dialogs/title_screen.cpp
    M src/preferences/game.cpp
    M src/preferences/game.hpp
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  gui2/mp_connect: Overhaul dialog adding a more powerful server list

There has been functionality to manage custom servers in the player's
preferences file since as far back as commit
5fb0b2a91123474d147c9de4918fc11a1b4c15ac in June 2007, but there's never
been a user interface for it.

This commit removes the current server list dialog attached to the MP
Connect dialog and replaces it with the same functionality embedded into
the latter, as well as the ability to edit the server list in the
player's preferences file. There's some code movement in a few other
places since the previous function in the preferences namespace doesn't
suit the new code (it always returned a combined list of game and
player-defined servers).

There's some disabled code referencing a situation where the listbox
with the list of servers allows the code (and the player) to clear the
selection. It's disabled because there are some UX issues with it noted
in the code comments associated to it.

Fixes #4564.


  Commit: 1cf49cc6d96cfd276e69e6e8a1691a7e1d9a8ea7
      https://github.com/wesnoth/wesnoth/commit/1cf49cc6d96cfd276e69e6e8a1691a7e1d9a8ea7
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-17 (Sun, 17 Nov 2019)

  Changed paths:
    M changelog.md

  Log Message:
  -----------
  Update changelog for issue #4564

[ci skip]


  Commit: 2e9bf3e0d1ef1176a76dfa3ce1f75aeabceebaab
      https://github.com/wesnoth/wesnoth/commit/2e9bf3e0d1ef1176a76dfa3ce1f75aeabceebaab
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2019-11-17 (Sun, 17 Nov 2019)

  Changed paths:
    M src/game_config.hpp
    M src/preferences/game.cpp

  Log Message:
  -----------
  Minor code cleanups

 * Remove the redundant explicitly-defined default ctor for
   game_config::server_info() as it does nothing than the compiler's
   default doesn't already do.

 * Use emplace_back() in the only way that works without giving the
   compiler a migraine.


Compare: https://github.com/wesnoth/wesnoth/compare/c98dd7bad3d9...2e9bf3e0d1ef