[wesnoth-commits] [wesnoth/wesnoth] c17740: GUI2/Tree View Node: used std::make_shared when po...

Sat Oct 19 08:21:56 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c1774005a9108a5c782faa8a4710e7c4fcda29c6
      https://github.com/wesnoth/wesnoth/commit/c1774005a9108a5c782faa8a4710e7c4fcda29c6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  GUI2/Tree View Node: used std::make_shared when possible

Child nodes were still managed with unique_ptrs in 1.14, so we couldn't use make_unique
there. Child nodes are now managed with shared_ptrs here on master.

  Commit: e8fb9225166f46ed000a2119ba3455b267290ae5
      https://github.com/wesnoth/wesnoth/commit/e8fb9225166f46ed000a2119ba3455b267290ae5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view_node.cpp

  Log Message:
  -----------
  GUI2/Tree View [Node]: formatting cleanup

  Commit: 2adac53461b62d3f1aa30b496759451555c5361e
      https://github.com/wesnoth/wesnoth/commit/2adac53461b62d3f1aa30b496759451555c5361e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/gamestate_inspector.cpp
    M src/gui/dialogs/help_browser.cpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/tree_view_node.cpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2/Tree View: use NOTIFY_MODIFIED events instead of manual callbacks

Unlike other widgets where `this` is the event target, the tree nodes fire the event
with the tree widget itself as the target.

I had added a fire-event call in f97dc8ae12be1b8982ab87b748266f915a84e15d, but with
the target as the node. I don't think there was any way that would have worked...
changed.

  Commit: 021339bcc58a347f28607315d9d5fe94546dcba8
      https://github.com/wesnoth/wesnoth/commit/021339bcc58a347f28607315d9d5fe94546dcba8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M data/core/macros/deprecated-utils.cfg

  Log Message:
  -----------
  Removed macros deprecated at level 2 and 3

[ci skip]

  Commit: a766d2d93a57ca99cc582935b9b325a01648dffb
      https://github.com/wesnoth/wesnoth/commit/a766d2d93a57ca99cc582935b9b325a01648dffb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp

  Log Message:
  -----------
  Removed a bunch of things deprecated at level 3

* [combo] in [modification]s
* Support for legacy DescriptionWML in the MP Faction Select dialog

  Commit: 92c7d2fed0bebed20855e4ad3bdaf911521cd8d7
      https://github.com/wesnoth/wesnoth/commit/92c7d2fed0bebed20855e4ad3bdaf911521cd8d7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  Removed deprecated put_unit arg orders

x, y, unit and plain unit

  Commit: 871e857771ed08abafa78be9072656444cf24876
      https://github.com/wesnoth/wesnoth/commit/871e857771ed08abafa78be9072656444cf24876
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M data/core/macros/deprecated-utils.cfg

  Log Message:
  -----------
  Begone, MENU_IMG_TXT!

[ci skip]

This utilized the deprecated DescriptionWML syntax.

  Commit: 97acce20643ba757e11fdf0cfa35994224ccda63
      https://github.com/wesnoth/wesnoth/commit/97acce20643ba757e11fdf0cfa35994224ccda63
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M data/core/macros/deprecated-utils.cfg

  Log Message:
  -----------
  Removed deprecated objective text macros

[ci skip]

These are incorporated into the objectives dialog automatically. They lack a deprecation
notice, but they should be given level 3 status on the 1.14 branch.

  Commit: b0d18afd2fedac3ad16c2de847783035de710ddd
      https://github.com/wesnoth/wesnoth/commit/b0d18afd2fedac3ad16c2de847783035de710ddd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/core/canvas.cpp
    M src/gui/core/event/distributor.cpp
    M src/gui/core/notifier.hpp
    M src/gui/core/timer.cpp

  Log Message:
  -----------
  GUI2: praise auto

  Commit: 167f4a1a1e55c3cf062397113696c1d1219b916d
      https://github.com/wesnoth/wesnoth/commit/167f4a1a1e55c3cf062397113696c1d1219b916d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/core/placer.cpp
    M src/gui/core/placer.hpp
    M src/gui/widgets/pane.cpp
    M src/gui/widgets/pane.hpp

  Log Message:
  -----------
  GUI2: dropped a remaining t-prefix from a type

  Commit: 9967dde327d36d0f5888b1f735c782e8758ddc90
      https://github.com/wesnoth/wesnoth/commit/9967dde327d36d0f5888b1f735c782e8758ddc90
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_join_game.hpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp
    M src/synced_context.cpp

  Log Message:
  -----------
  Cleaned up a few unnecessary AI-related includes outside ai/

  Commit: 9a7b11f08f89fe4167fba344611e0d17798a4aff
      https://github.com/wesnoth/wesnoth/commit/9a7b11f08f89fe4167fba344611e0d17798a4aff
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/image_modifications.cpp

  Log Message:
  -----------
  IPFs: simplify ~TC() implementation

This results in the same behavior as before (default color outside a scenario, side's
chosen color during one) and is more consistent with other places in the code. They
both end up accessing `game_config::team_rgb_range` anyway, this is just in a slightly
more roundabout way.

  Commit: e643d2dce738c2426a64ce15bc2d87ee49130aee
      https://github.com/wesnoth/wesnoth/commit/e643d2dce738c2426a64ce15bc2d87ee49130aee
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M changelog.md
    M data/advanced_preferences.cfg
    M source_lists/libwesnoth
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/game_launcher.cpp
    M src/game_launcher.hpp
    M src/hotkey/hotkey_item.cpp
    M src/hotkey/hotkey_item.hpp
    R src/joystick.cpp
    R src/joystick.hpp
    M src/preferences/general.cpp
    M src/preferences/general.hpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Removed joystick code

This was never fully implemented and has been essentially abandoned. If we want to
add this again, we should look to adding full game controller support (Steam controller,
for example), though I don't know how suited this game is for controller support. As for
as I can tell, the only working part was ever map scrolling.

Includes a sqrt -> std::sqrt conversion I forgot in this file awhile back.

  Commit: 619ceabb9dc0ad0e1f5d30b56f2e716a5df48ea3
      https://github.com/wesnoth/wesnoth/commit/619ceabb9dc0ad0e1f5d30b56f2e716a5df48ea3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/lobby_data.hpp

  Log Message:
  -----------
  Lobby Data: removed unused era_short field

  Commit: ab0197343e4248d432751c94a22d68d8cfc4f3ee
      https://github.com/wesnoth/wesnoth/commit/ab0197343e4248d432751c94a22d68d8cfc4f3ee
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/addon/validation.cpp
    M src/commandline_options.cpp
    M src/game_initialization/connect_engine.cpp
    M src/generators/lua_map_generator.cpp
    M src/replay.cpp
    M src/units/types.cpp
    M src/units/unit.cpp

  Log Message:
  -----------
  Convert a bunch of C-style arrays to std::array

  Commit: 3c01a4350b936f4548a42a69dabcab6b3f6a2aa7
      https://github.com/wesnoth/wesnoth/commit/3c01a4350b936f4548a42a69dabcab6b3f6a2aa7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/scripting/plugins/context.hpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Plugins/Context: removed C-style array ctor and use

This likely existed because this code was added in 2014 before we switched to C++11
and initializer lists.

  Commit: de8077add61ff241aadbb912c7f709eda8f74672
      https://github.com/wesnoth/wesnoth/commit/de8077add61ff241aadbb912c7f709eda8f74672
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp
    M src/units/types.cpp

  Log Message:
  -----------
  Sneaky C-style arrays be hiding

Also dropped some unused code in unit_type.

And there's still one in language.cpp, but I'm not entirely sure if it's safe to
drop the last empty entry there so I left it.

  Commit: 8587a14cdee54d631657332274966993c8ba4e7f
      https://github.com/wesnoth/wesnoth/commit/8587a14cdee54d631657332274966993c8ba4e7f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M changelog.md
    M data/advanced_preferences.cfg
    M src/display.cpp
    M src/halo.cpp
    M src/preferences/game.cpp
    M src/preferences/game.hpp

  Log Message:
  -----------
  Removed preference to disable halos

There's really no reason to have this anymore. It was (AFAIK) introduced years ago
as a performance-saving measure, then was moved to Advanced Preferences in 1.13 since
modern PCs mostly have no issues.

  Commit: c15cb0696e2791de184b08e6ede3705e720f5e95
      https://github.com/wesnoth/wesnoth/commit/c15cb0696e2791de184b08e6ede3705e720f5e95
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/addon/client.cpp
    M src/formula/debugger.cpp
    M src/game_initialization/depcheck.cpp
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/addon/install_dependencies.hpp
    M src/gui/dialogs/chat_log.hpp
    M src/gui/dialogs/depcheck_confirm_change.hpp
    M src/gui/dialogs/formula_debugger.hpp
    M src/gui/dialogs/game_save.hpp
    M src/gui/dialogs/gamestate_inspector.hpp
    M src/gui/dialogs/multiplayer/mp_change_control.hpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp
    M src/gui/dialogs/multiplayer/synced_choice_wait.hpp
    M src/gui/dialogs/transient_message.hpp
    M src/menu_events.cpp
    M src/scripting/lua_gui2.cpp
    M src/synced_user_choice.cpp

  Log Message:
  -----------
  GUI2: added display and execute wrappers for a bunch more dialogs

Made use of them where applicable. There are a whole bunch of cases where the dialog
object only exists to check its return value, but I'll update those separately.

  Commit: 4a5d34d1be2b98a701513d37f762716d8e89ed92
      https://github.com/wesnoth/wesnoth/commit/4a5d34d1be2b98a701513d37f762716d8e89ed92
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/widgets/grid.hpp

  Log Message:
  -----------
  GUI2/Grid: made use of std::exchange

  Commit: 773cc212b374b6738cf9f474adcf50d76ad3f097
      https://github.com/wesnoth/wesnoth/commit/773cc212b374b6738cf9f474adcf50d76ad3f097
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/animated.hpp
    M src/animated.tpp

  Log Message:
  -----------
  Animated: simplified template stuff

Just... why was T_void_value a thing.

  Commit: 7cedcb57ab4a4c4def60486f58d763a762af23ee
      https://github.com/wesnoth/wesnoth/commit/7cedcb57ab4a4c4def60486f58d763a762af23ee
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/mouse_events.cpp
    M src/mouse_events.hpp

  Log Message:
  -----------
  Mouse Events: removed an override that only called the base method

  Commit: dd02bdecc802dd9acc5ece8b591a877002a80d7d
      https://github.com/wesnoth/wesnoth/commit/dd02bdecc802dd9acc5ece8b591a877002a80d7d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M src/gui/widgets/pane.cpp

  Log Message:
  -----------
  Fixup 167f4a1a1e55c

  Commit: 388913162c9180b7baa38434d5e492f3d63bc115
      https://github.com/wesnoth/wesnoth/commit/388913162c9180b7baa38434d5e492f3d63bc115
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M projectfiles/VC16/wesnoth.vcxproj
    M projectfiles/VC16/wesnoth.vcxproj.filters

  Log Message:
  -----------
  Updated VS2019 projectfile

Compare: https://github.com/wesnoth/wesnoth/compare/36b4b24a8fc5...388913162c91